1642578 - Disable breakpoints shortcut

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[fatcorreia94]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Firefox/78.0

Expected results:

As a developer, it would be helpful if there was a keyboard shortcut to disable/enable all breakpoints instead of having to click the existent button.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

Honza

Comment 2

[Jason Laster [:jlast]]

Great idea, i think cmd+shift+b would be perfect.

Would you like to work on this?

Comment 3

[Will Hernandez]

Hello! If this enhancement is not yet claimed, would it be possible for me to claim it?
Also cmd+shift+b is the current key shortcut for (Toggle conditional breakpoint on the currently selected line). Would this be assigned to another key shortcut? Thanks!

Comment 4

[Will Hernandez]

Attachment: Bug 1642578 - Disable breakpoints shortcut r=davidwalsh

Bug 1642578 - Disable breakpoints shortcut, r=davidwalsh

Comment 5

[BugBot [:suhaib / :marco]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:bomsy, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Hubert Boma Manilla (:bomsy)]

Hey Will,
Its been a while. Are you willing to finish this up?

Comment 7

[BugBot [:suhaib / :marco]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:bomsy, since the bug has recent activity, could you please find another way to get the information or close the bug as INCOMPLETE if it is not actionable?

For more information, please visit BugBot documentation.

Comment 8

[Hubert Boma Manilla (:bomsy)]

Anyone else can pick this up!

Comment 9

[Rajvardhan]

Hello I am new to the open source world and knows javascript and React , I am looking to get my feet in this repo to start contributing here it is mentioned as good first issue will it be possible for me to work on this ?

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Rajvardhan from comment #9)

Hello I am new to the open source world and knows javascript and React , I am looking to get my feet in this repo to start contributing here it is mentioned as good first issue will it be possible for me to work on this ?

Hello Rajvardhan, you can go for it :)
If you haven't already, you can go through https://firefox-source-docs.mozilla.org/devtools/index.html to get information on how to get started

Comment 11

[BugBot [:suhaib / :marco]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 12

[Franccesco]

Hello, I would love to pick this bug up, could this possibly be assigned to me please? Thank you!

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Franccesco from comment #12)

Hello, I would love to pick this bug up, could this possibly be assigned to me please? Thank you!

sure, it's yours now :)
let us know if you have any question

Comment 14

[BugBot [:suhaib / :marco]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 15

[Osoble]

Hi can i work on this if nobody else is?

Comment 16

[Hubert Boma Manilla (:bomsy)]

Sure go ahead. and open a patch for it.
Assigned to you.
Let us know if you have any questions.
Thanks

Comment 17

[Osoble]

Hi i've just read through some of the documentation, it's a little unclear of exactly what's being asked here, do you require me to change the disable breakpoints shortcut to or from cmd+shift+b?

Comment 18

[BugBot [:suhaib / :marco]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 19

[K]

Hi! I see that this bug is currently unassigned and I’d be interested in working on it.

Before I begin could someone confirm the preferred shortcut on macOS, Windows and Linux? Earlier comments mention that Cmd/Ctrl+Shift+B may conflict with the existing conditional-breakpoint shortcut.

I’d like to propose Cmd+Option+B on macOS and Ctrl+Alt+B on Windows/Linux for toggling all breakpoints but I’m open to other suggestions.

Thank you!

Comment 20

[K]

Hi! Just a friendly ping 🙂 Could someone please share their thoughts on which shortcut would best align with Firefox conventions?

Comment 21

[K]

Attachment: Bug 1642578 - Add disable/enable all breakpoints shortcut. r=bomsy,#devtools-reviewers

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd15e657b3ff
https://hg.mozilla.org/integration/autoland/rev/285792072f21
Add disable/enable all breakpoints shortcut. r=bomsy,devtools-reviewers

Comment 23

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/285792072f21

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for the Fx155 relnotes? If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

The Debugger in Developer Tools now has a keyboard shortcut, Ctrl+Alt+B (Cmd+Alt+B on macOS), to enable or disable all breakpoints at once.