1642593 - Optimize GuardToClass intrinsics in CacheIR and Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Tom S [:evilpie]]

This will allow us to inline all instructions like IntrinsicGuardToArrayIterator, IntrinsicGuardToSetObject etc.

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1642593 - Create a InlinableNativeGuardToClass function to allow for more code sharing. r?jandem!

Comment 2

[Tom S [:evilpie]]

Attachment: Bug 1642593 - Support GuardToClass in CacheIR. r?jandem!

Depends on D77791

Comment 3

[Tom S [:evilpie]]

Attachment: Bug 1642593 - Transpile GuardAnyClass. r?jandem!

Depends on D77792

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/249b7000aaf8
Create a InlinableNativeGuardToClass function to allow for more code sharing. r=jandem
https://hg.mozilla.org/integration/autoland/rev/6f7ef41e1713
Support GuardToClass in CacheIR. r=jandem
https://hg.mozilla.org/integration/autoland/rev/4fc6b0a08a29
Transpile GuardAnyClass. r=jandem

Comment 5

[Cristian Brindusan [:cbrindusan]]

Backed out 3 changesets (Bug 1642593) for sm bustages on InlinableNatives.h.
https://hg.mozilla.org/integration/autoland/rev/b3f2a9279984e2376a37d4737a21ea662a859d26

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=4fc6b0a08a293697b99834cd4f19fa10c96f34a7&selectedTaskRun=LGD6CHqsRbGElNh9NLr8VQ-0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304802328&repo=autoland&lineNumber=6748

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca5509801aab
Create a InlinableNativeGuardToClass function to allow for more code sharing. r=jandem
https://hg.mozilla.org/integration/autoland/rev/aa20bf181fd0
Support GuardToClass in CacheIR. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ce2ec4204fe8
Transpile GuardAnyClass. r=jandem

Comment 7

[Tom S [:evilpie]]

Attachment: Bug 1642593 - Fix non unified

Depends on D77793

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31834414f0f0
Fix non unified

Comment 9

[Tom S [:evilpie]]

Sorry for screwing up the build twice. I need to figure out how to do try runs for non-unified.

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ca5509801aab
https://hg.mozilla.org/mozilla-central/rev/aa20bf181fd0
https://hg.mozilla.org/mozilla-central/rev/ce2ec4204fe8
https://hg.mozilla.org/mozilla-central/rev/31834414f0f0