1642602 - Some disk cache values in about:cache are incorrect.

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect, P3)

Description

[Gary [:streetwolf52]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Go to about:cache.

Observe 'Number of entries' and 'Storage in use.'

Actual results:

'Number off entries' and 'Storage in use' are greatly under reported.

Expected results:

The stats should be correctly reported. Here is an example from my system:

ABOUT:CACHE
disk
Number of entries: 732
Maximum storage size: 1048576 KiB
Storage in use: 16699 KiB
Storage disk location: D:\cache2

When I look at the cache folder in file manager it is 1Gb (fully utilized) with over 18,000 files. I cleared my cache many times with the same result.

Comment 1

[Dragana Damjanovic [:dragana]]

Honza, is this related to the issue you reported some time ago?

Comment 2

[Hani Yacoub, Desktop QA]

Attachment: cache.png

Gary, I need more details here please in order to provide a regression window.
Do you compare the info for about:cache from disk section with "Cache2" folder properties? (Please see screenshot attached)
Thanks.

Comment 3

[Gary [:streetwolf52]]

Attachment: cache screenshots

Per your request.

Comment 4

[Honza Bambas (:mayhemer)]

Michal, as I remember, we take this information from the index - could it be some problem with rebuilding it?

Comment 5

[Michal Novotny [:michal]]

(In reply to Honza Bambas (:mayhemer) from comment #4)

Michal, as I remember, we take this information from the index - could it be some problem with rebuilding it?

This is because the stats is shown according to the filter at the top of the page. I'm not even sure whether all combinations of private/anonymous will cover all entries or whether using specific origin attributes or idExtension will make the entries inaccessible in about:cache. Honza, you should know this better.

Comment 6

[Honza Bambas (:mayhemer)]

I can reproduce something weird with my regular profile too. We don't have (good) automated testing for this, so bugs can be easily missed. I'll take a look.

Comment 7

[abodenlosz]

Managed to reproduce the issue with Nightly 79.0a1 (2020-06-02).
Regression window:

• Last good: 2017-08-11
• First bad: 2017-08-12
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=47248637eafa9a38dade8dc3aa6c4736177c8d8d&tochange=80ff3f300e05f38f96c385b03d1973a966a2bd35
  Not sure of possible regressor

Comment 8

[Honza Bambas (:mayhemer)]

(In reply to abodenlosz from comment #7)

Managed to reproduce the issue with Nightly 79.0a1 (2020-06-02).
Regression window:

• Last good: 2017-08-11
• First bad: 2017-08-12
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=47248637eafa9a38dade8dc3aa6c4736177c8d8d&tochange=80ff3f300e05f38f96c385b03d1973a966a2bd35
  Not sure of possible regressor

Thanks. This could be bug 1369051. Michal, do you see any relation between the symptoms and that bug?

Comment 9

[Michal Novotny [:michal]]

Please see my comment #5. Numbers in about:cache don't report all entries in the cache, it's a filtered view. Bug 1369051 isn't anyhow related to it.

Comment 10

[Honza Bambas (:mayhemer)]

Attachment: Bug 1642602 - Make about:cache show all entries, remove the no longer usable context switch UI, r=michal

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b056b29e7fc
Make about:cache show all entries, remove the no longer usable context switch UI, r=michal,necko-reviewers

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1b056b29e7fc

Comment 13

[abodenlosz]

Confirmed the issue with Nightly 79.0a1 (2020-06-02) on Windows 10 x64.
Verified with Nightly 80.0a1 (2020-07-07) on windows 10 x64. Updating the flag to verified.