1642635 - Improve text wrapping in calendar-item-summary custom element

Status: RESOLVED FIXED

(Calendar :: Dialogs, enhancement, P3)

Description

[Paul Morris [:pmorris]]

Let the text wrap in the right hand column of the summary table, particularly needed for date fields. Follow-up on bug 1631902, continuing the work of the part3 WIP patch there.

Comment 1

[Paul Morris [:pmorris]]

Attachment: Bug 1642635 - Rename CSS file for calendar-item-summary custom element. r?darktrojan

All of the styles in the file are for that custom element.

Comment 2

[Paul Morris [:pmorris]]

Attachment: Bug 1642635 - Re-indent XUL/HTML in calendar-item-summary custom element. r?darktrojan

Some XUL elements will be removed in the next patch. Do the
re-indentation first and separately to make the patches easier
to follow.

Depends on D77974

Comment 3

[Paul Morris [:pmorris]]

Attachment: Bug 1642635 - Let text wrap in item summary table and improve alignment. r=darktrojan

For lengthy content like dates with timezones we want the content
to wrap, not disappear on the right side of dialogs. Removing the
HTML input elements allows us to do that.

Depends on D77975

Comment 4

[Paul Morris [:pmorris]]

Attachment: Bug 1642635 - Put repeat details on one line in calendar item summary. r=darktrojan

Depends on D77976

Comment 5

[Paul Morris [:pmorris]]

Attachment: Bug 1642635 - Rearrange recurrence string function imports. r=darktrojan

It was confusing and awkward to have to import
recurrenceRule2String in order to use getRecurrenceRule.

Depends on D77977

Comment 6

[Paul Morris [:pmorris]]

Thanks Geoff for the review. I've made the suggested changes. Here's a try run, just started:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=e4d2007cf4afae4f31d27bc992a83ca5a716c2c3

Comment 7

[Paul Morris [:pmorris]]

Geoff, I'd like to request your beta uplift approval for these patches, but I don't see how to do that on Phabricator. Any idea how that works?

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9153695 [details]
Bug 1642635 - Rename CSS file for calendar-item-summary custom element. r?darktrojan

This seems to work. I don't think I'm supposed to grant approval until the patch has landed, but I'm doing it now while I'm here.

Comment 9

[Paul Morris [:pmorris]]

I've now updated the browser_import.js test so that it passes, and uploaded the new revision to phabricator.
New successful try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d296ab88411eeca49b8c947795c59eacbfca8528

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/84a25e6535b4
Rename CSS file for calendar-item-summary custom element. r=darktrojan
https://hg.mozilla.org/comm-central/rev/06ee3df59f65
Re-indent XUL/HTML in calendar-item-summary custom element. r=darktrojan
https://hg.mozilla.org/comm-central/rev/b7ff2f88b6a9
Let text wrap in item summary table and improve alignment. r=darktrojan
https://hg.mozilla.org/comm-central/rev/bcc6a5540e04
Put repeat details on one line in calendar item summary. r=darktrojan
https://hg.mozilla.org/comm-central/rev/43f7fed980d9
Rearrange recurrence string function imports. r=darktrojan

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/55b499fa3ad8
https://hg.mozilla.org/releases/comm-beta/rev/fdb016c8e6c5
https://hg.mozilla.org/releases/comm-beta/rev/b9ef529352b6
https://hg.mozilla.org/releases/comm-beta/rev/a3d447848238
https://hg.mozilla.org/releases/comm-beta/rev/22701eacd771