1642665 - [wayland] layout.css.devPixelsPerPx > 1 menu offset wrong

Status: RESOLVED DUPLICATE of bug 1634404

(Core :: Widget: Gtk, defect, P2)

Description

[Jan Gerber]

with layout.css.devPixelsPerPx > 1 the menu of the menu burger does not show up at the right position.

Comment 1

[Jan Gerber]

Attachment: menu-offset-firefox-2020-06-02.png

Comment 2

[:Gijs (he/him)]

What's the actual value of layout.css.devPixelsPerPx, have you restarted since setting it, and what OS / window manager / desktop software is in use (and what version)? Also, the screenshot looks like Linux to me - are you using X11 or wayland?

Comment 3

[Jan Gerber]

it used to work, so this is a recent regression. value of layout.css.devPixelsPerPx is 1.25
This is on Linux/Wayland

Comment 4

[:Gijs (he/him)]

(In reply to Jan Gerber from comment #3)

it used to work, so this is a recent regression. value of layout.css.devPixelsPerPx is 1.25
This is on Linux/Wayland

Recent regression on nightly? On release? When did it last work? Did you try restarting the browser and does that help or not? Can you please answer the other questions from comment #2 ?

Comment 5

[Jan Gerber]

Yes, restarted Firefox multiple times, tested with 78.0b2 (64-bit) on Linux/Gnome 3.36.2/Wayland.
It does not happen with 68. Just tested with nightly 79.0a1 (2020-06-04) and that also has the issue:

Menu offset ok with layout.css.devPixelsPerPx: -1
Menu offset wrong with layout.css.devPixelsPerPx: 1.25

Comment 6

[:Gijs (he/him)]

(In reply to Jan Gerber from comment #5)

Yes, restarted Firefox multiple times, tested with 78.0b2 (64-bit) on Linux/Gnome 3.36.2/Wayland.
It does not happen with 68

There are tens, maybe hundreds of thousands of commits that separate 78.0b2 and 68. Any chance you can narrow this window down a bit more?

Anyway, given it doesn't happen on other OSes, this is probably a widget bug of sorts.

Comment 7

[Jan Gerber]

just updated from an older version and 76.1 still was ok and latest stable 77 is already broken.

Comment 8

[:Gijs (he/him)]

I can't reproduce on my ubuntu vm, but that's running X, so it seems wayland related. Hopefully the widget folks have a better idea of what's going on.

Comment 9

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Can you attach info from your about:support please?
Thanks.

Comment 10

[Negritas Sergiu, Desktop QA]

Hello I wasn't able to reproduce the issue using Ubuntu 18.04 LTS, Windows 10 and MacOS 10.15 with Firefox Nightly 79.0a1 (2020-06-08).

Comment 11

[Jan Gerber]

Attachment: firefox-support.json

(In reply to Martin Stránský [:stransky] from comment #9)

Can you attach info from your about:support please?
Thanks.

raw data of up to date firefox nightly profile attached

Comment 12

[Jan Gerber]

(In reply to Negritas Sergiu from comment #10)

Hello I wasn't able to reproduce the issue using Ubuntu 18.04 LTS, Windows 10 and MacOS 10.15 with Firefox Nightly 79.0a1 (2020-06-08).

Just did more testing on a fresh Ubuntu 20.04 install. This only happens with the Wayland backend. You need to run a Wayland Session (Ubuntu on Wayland or Gnome) and in addition have set: export MOZ_ENABLE_WAYLAND=1

Comment 13

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Jan, can you look at it please?
Thanks.

Comment 14

[Sibo Dong]

I believe this is the same issue as bug 1634404. As implied in the original report, the menus are offset not just when layout.css.devPerPixelsPerPx is greater than 1.0, but whenever it isn't equal to 1.0 or -1.0.

Comment 15

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Last good build: 2020.04.21 (20200421222503)
First bad: 2020.04.22 (20200422214848)
Push log: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=263963426b561b2aa687aeeaeddc4fd93fff9e57&tochange=17aa41e3cb7cdff3b94e26e351e29cc8b9bab18a
Potential regressor: Bug 1623974.
I tried to do regression with mozregression-gui, but i couldn't enable the wayland session before the build started in mozregression, so I do it manually. Hope this helps.