1642675 - Make the calendar preferences look better aligned

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

The calendar prefs need a more homogenous sizing of the menulists in the first block. And the categories list with its buttons could look like the tags list to be more consistent in the prefs.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1642675-calendar-preferences.patch

I'm asking aleca for review because this is more review about UI changes.

Comment 2

[Alessandro Castellani [:aleca]]

Comment on attachment 9153461 [details] [diff] [review]
1642675-calendar-preferences.patch

Review of attachment 9153461 [details] [diff] [review]:
-----------------------------------------------------------------

This is very good, thank you for taking care of it, just a CSS nit.

Can you also update the commit message with: "Improve the alignment of the sections in the Calendar Preferences tab"

::: calendar/base/content/preferences/views.inc.xhtml
@@ +3,5 @@
>  # file, you can obtain one at http://mozilla.org/MPL/2.0/.
>  
>      <html:fieldset data-category="paneCalendar">
>          <separator/>
> +        <box style="display:grid; grid-template-columns: auto 1fr 1fr;">

Let's avoid inline style as much as possible and put this in the CSS.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1642675-calendar-preferences.patch

Moved the grid style to preferences.css.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/42d651f7162a
Improve the alignment of the sections in the Calendar Preferences tab. r=aleca

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/a548cd3b25e3