Open Bug 1642693 Opened 1 year ago Updated 1 year ago

Artifacts sometimes appear at the edges of filtered elements

Categories

(Core :: Graphics: WebRender, defect)

defect

Tracking

()

Tracking Status
firefox-esr68 --- disabled
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- fix-optional

People

(Reporter: cbrewster, Unassigned)

References

Details

(Keywords: correctness)

Attachments

(2 files)

Attached file test-case.html

Sometimes artifacts can be seen on the edge of filtered elements. The artifacts can be reproduced more often if a perspective transform is also applied to the filtered element. Additionally, pinch-zooming can cause the artifact to disappear/reappear.

I think this is because we are not insetting the UV sample bounds by 0.5 pixels in all directions in the brush_blend shader. The inset ensures that bordering pixels are not included when sampling from the render task region.

see comment here: https://searchfox.org/mozilla-central/source/gfx/wr/webrender/res/brush_blend.glsl#87-88

Attachment #9153483 - Attachment mime type: text/plain → text/html
Attached image artifacts.png
Severity: -- → S2
Flags: needinfo?(jbonisteel)

Seems like this has been around for a while, probably not an S2

Severity: S2 → S3
Flags: needinfo?(jbonisteel)
No longer blocks: gfx-triage
You need to log in before you can comment on or make changes to this bug.