1642735 - Assertion failure: !Failed(), at /builds/worker/workspace/obj-build/dist/include/mozilla/ErrorResult.h:582

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Tyson Smith [:tsmith]]

This issue is hit by fuzzers frequently and can limit the effectiveness of the fuzzers. Please prioritize it accordingly.

A reduced test case will be attached asap.

Assertion failure: !Failed(), at /builds/worker/workspace/obj-build/dist/include/mozilla/ErrorResult.h:582

0|0|libxul.so|mozilla::binding_danger::TErrorResult<mozilla::binding_danger::AssertAndSuppressCleanupPolicy>::~TErrorResult()|hg:hg.mozilla.org/mozilla-central:dom/bindings/ErrorResult.h:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|0|0x29
0|1|libxul.so|mozilla::ChromiumCDMProxy::RejectPromiseWithStateError(unsigned int, nsTString<char> const&)|hg:hg.mozilla.org/mozilla-central:dom/media/gmp/ChromiumCDMProxy.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|386|0x8
0|2|libxul.so|mozilla::ChromiumCDMProxy::Init(unsigned int, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&)::$_11::operator()() const::{lambda(RefPtr<mozilla::gmp::ChromiumCDMParent>)#1}::operator()(RefPtr<mozilla::gmp::ChromiumCDMParent>) const::{lambda(bool)#1}::operator()(bool) const|hg:hg.mozilla.org/mozilla-central:dom/media/gmp/ChromiumCDMProxy.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|106|0x8
0|3|libxul.so|mozilla::MozPromise<bool, mozilla::MediaResult, true>::ThenValue<mozilla::ChromiumCDMProxy::Init(unsigned int, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&)::$_11::operator()() const::{lambda(RefPtr<mozilla::gmp::ChromiumCDMParent>)#1}::operator()(RefPtr<mozilla::gmp::ChromiumCDMParent>) const::{lambda(bool)#1}, mozilla::ChromiumCDMProxy::Init(unsigned int, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&, nsTSubstring<char16_t> const&)::$_11::operator()() const::{lambda(RefPtr<mozilla::gmp::ChromiumCDMParent>)#1}::operator()(RefPtr<mozilla::gmp::ChromiumCDMParent>) const::{lambda(mozilla::MediaResult)#1}>::DoResolveOrRejectInternal(mozilla::MozPromise<bool, mozilla::MediaResult, true>::ResolveOrRejectValue&)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/MozPromise.h:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|771|0x16
0|4|libxul.so|mozilla::MozPromise<bool, mozilla::MediaResult, true>::ThenValueBase::ResolveOrRejectRunnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/MozPromise.h:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|410|0x2b
0|5|libxul.so|mozilla::SchedulerGroup::Runnable::Run()|hg:hg.mozilla.org/mozilla-central:xpcom/threads/SchedulerGroup.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|146|0x11
0|6|libxul.so|nsThread::ProcessNextEvent(bool, bool*)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|1211|0x11
0|7|libxul.so|NS_ProcessNextEvent(nsIThread*, bool)|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|501|0xc
0|8|libxul.so|mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|109|0x14
0|9|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|315|0x17
0|10|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|290|0x8
0|11|libxul.so|nsBaseAppShell::Run()|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|137|0xd
0|12|libxul.so|XRE_RunAppShell()|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|909|0xe
0|13|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*)|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|237|0x5
0|14|libxul.so|MessageLoop::RunInternal()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|315|0x17
0|15|libxul.so|MessageLoop::Run()|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|290|0x8
0|16|libxul.so|XRE_InitChildProcess(int, char**, XREChildData const*)|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|740|0x5
0|17|firefox-bin|content_process_main(mozilla::Bootstrap*, int, char**)|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|56|0x11
0|18|firefox-bin|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|303|0x20
0|19|libc.so.6||||0x21b97
0|20|firefox-bin|<name omitted>|hg:hg.mozilla.org/mozilla-central:mfbt/UniquePtr.h:8acda9da4ae71f0b6561cb2021bcb370e18ce80c|253|0x1d

Comment 1

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

I've seen this before but couldn't find that bug (maybe I've just seen it while debugging...). Reminder to myself to take another look.

Comment 2

[Tyson Smith [:tsmith]]

A Pernosco session is available here: https://pernos.co/debug/29fjQFq9I_QGfihR2zsRRg/index.html

Comment 3

[Intermittent Failures Robot]

1 failures in 4949 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1642735&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 4

[Jason Kratzer [:jkratzer]]

Attachment: testcase.html

The attached testcase can be used with grizzly to reproduce this issue.

pip install grizzly-framework
python3 -m grizzly.replay --xvfb ~/builds/mc-debug/firefox ./testcase.html  -p prefs.js --repeat 20

Comment 5

[Jason Kratzer [:jkratzer]]

Attachment: prefs.js

Comment 6

[Jon Bauman [:jbauman:]]

I've been hitting this a fair amount in my work on a different bug, so I'll be pitching in here as well.

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Attachment: Bug 1642735 - Suppress exceptions in ChromiumCDMProxy if we don't have MediaKeys. r?jbauman

When rejecting promises in ChromiumCDMProxy we pass an exception to MediaKeys to
represent the error that took place. However, if we do not have a any keys the
exception is not passed anywhere. Since these exceptions will assert on
destruction that they were handled we need to explicitly suppress the exception
when we don't have MediaKeys to avoid firing asserts.

The case we hit this issue in is during browser shutdown, so I think it makes
sense to ignore the exception. This is not a case of simply ignoring an
exception when it can be handled, this is that we're in a state where various
machinery is becoming unavailable and where it makes sense to not try and send
the exception any further.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f67698e1e52
Suppress exceptions in ChromiumCDMProxy if we don't have MediaKeys. r=jbauman

Comment 9

[Natalia Csoregi [:nataliaCs]]

Backed out: https://hg.mozilla.org/integration/autoland/rev/25389e8dcd237591543f6c69e030dfde90af60b5

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdaabda9a455
Suppress exceptions in ChromiumCDMProxy if we don't have MediaKeys. r=jbauman

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/fdaabda9a455