(In reply to Molly Howell (she/her) [:mhowell] from comment #3)
To be entirely clear, we do need one condition on sending
update-downloaded, which is to skip it if staging is enabled (and succeeds), because then we don't want to start any prompting until that's done.
Ah, right. We need to preserve the
shouldShowPrompt concept. I should have said that the
if (this.background) checks can be removed from
But the reasoning here for removing the background condition does seem right to me. It's occurred to me now that when that condition was written, we had prompts that were very invasive compared to what we have today, and I think that relieves us of the need to treat them so cautiously.
I'm no longer even sure that we need to add the condition on whether the UI that initiated the foreground check is still open; it seems like a justifiable condition to have, but not a necessary or even really useful one.
Yes, that is what I am arguing for: replace the check that is made against the Downloader's
.background value with... nothing. In fact, we can then remove the background property from
Downloader (it is not used for anything else).