1642769 - Debugger should show TypeScript icon for .TSX files

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[:Harald Kirschner :digitarald]

Attachment: image.png

STR:

• Open Debugger on https://excalidraw.com/
• /static/js/components/ contains a few TSX files

AR: Generic icon
ER: TypeScript or React icon

Comment 1

[Dennis Czombera]

Hey Harald,
can I work on this one? I fixed a similar bug for vue files, so I guess it will be similar (though I worked on it two years ago, so I have to setup everything first).

Comment 2

[:Harald Kirschner :digitarald]

Thank you, Dennis, it's all yours. Please reach out in our Debugger channels or here if you need any help.

Comment 3

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jlast, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Varun [he/him IST]]

Hey Herald. This seems inactive. Can I take this up?

Comment 5

[:Harald Kirschner :digitarald]

(Taking you off Dennis, but thank you for offering to help)

Varun, it's yours – thank you! David can help with guidance if needed.

Comment 6

[Varun [he/him IST]]

Hi David, can you help me where to get started with this? Tried reaching out to you on element as well.

Comment 7

[David Walsh :davidwalsh]

Hello Varun! I recommend looking in the following file:

https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/components/shared/SourceIcon.js

This component dictates source icons, so I recommend exploring the information provided by the source to see how we can determine typescript :)

Comment 8

[Varun [he/him IST]]

Attachment: Bug 1642769 - Show TypeScript icon for .tsx extension. r?davidwalsh

Depends on D84896

Comment 9

[Varun [he/him IST]]

Attachment: Screenshot 2020-08-06 at 4.05.53 PM.png

I noticed a weird thing here. On clicking the .tsx file, it shows a React icon. Though I have raised a PR for the original issue, this seems to be a separate bug since same thing happens even after we show TS icon for .tsx file type

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d40578774887
Show TypeScript icon for .tsx extension. r=davidwalsh

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d40578774887