Closed Bug 1642769 Opened 5 months ago Closed 3 months ago

Debugger should show TypeScript icon for .TSX files

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: Harald, Assigned: varundey20, Mentored)

Details

(Keywords: dev-doc-needed, good-first-bug)

Attachments

(3 files)

Attached image image.png

STR:

AR: Generic icon
ER: TypeScript or React icon

Hey Harald,
can I work on this one? I fixed a similar bug for vue files, so I guess it will be similar (though I worked on it two years ago, so I have to setup everything first).

Thank you, Dennis, it's all yours. Please reach out in our Debugger channels or here if you need any help.

Assignee: nobody → dczomb

The severity field is not set for this bug.
:jlast, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jlaster)

Hey Herald. This seems inactive. Can I take this up?

(Taking you off Dennis, but thank you for offering to help)

Varun, it's yours – thank you! David can help with guidance if needed.

Assignee: dczomb → varundey20
Mentor: dwalsh
Type: defect → enhancement
Flags: needinfo?(jlaster)

Hi David, can you help me where to get started with this? Tried reaching out to you on element as well.

Flags: needinfo?(dwalsh)

Hello Varun! I recommend looking in the following file:

https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/components/shared/SourceIcon.js

This component dictates source icons, so I recommend exploring the information provided by the source to see how we can determine typescript :)

Flags: needinfo?(dwalsh)

I noticed a weird thing here. On clicking the .tsx file, it shows a React icon. Though I have raised a PR for the original issue, this seems to be a separate bug since same thing happens even after we show TS icon for .tsx file type

Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d40578774887
Show TypeScript icon for .tsx extension. r=davidwalsh
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.