1642788 - Use mTimeStamp rather than mTime for APZ velocity computations

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P3)

Description

[Botond Ballo [:botond]]

mTime is not always set correctly, e.g. on Linux for synthesized events (we ran into this in bug 1621781). mTimeStamp is newer, higher resolution, and a nicer API to use. We should try to switch APZ over to using mTimeStamp if possible.

Comment 1

[Botond Ballo [:botond]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=74224457b9d219916e05e901933210974637a5e7

There are gtest failures, I'm guessing due to gtests not setting mTimeStamp correctly.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1642788 - Use mTimeStamp rather than mTime for APZ velocity computations. r=kats

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1642788 - Call StartTouch() when pinch locking is activated. r=kats

Activating pinch locking means we are locked into a two-finger pan
(no scaling), which can trigger a fling animation at the end. We
track velocity via UpdateWithTouchAtDevicePoint() while pinch locked.
We need to call StartTouch() when we start tracking velocity.

Depends on D77979

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1642788 - Ensure APZ gtests set mTimeStamp correctly on events where needed. r=kats

Depends on D77980

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7534525df6af
Use mTimeStamp rather than mTime for APZ velocity computations. r=kats
https://hg.mozilla.org/integration/autoland/rev/67ce8c8ddafe
Call StartTouch() when pinch locking is activated. r=kats
https://hg.mozilla.org/integration/autoland/rev/702cb5d63666
Ensure APZ gtests set mTimeStamp correctly on events where needed. r=kats

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7534525df6af
https://hg.mozilla.org/mozilla-central/rev/67ce8c8ddafe
https://hg.mozilla.org/mozilla-central/rev/702cb5d63666