1642811 - Rename UI references of "blackbox" to "ignore" in Debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[:Harald Kirschner :digitarald]

Follow up from https://github.com/firefox-devtools/ux/issues/84, we want to rename "blacklist" references to "ignore" in the UI.

https://searchfox.org/mozilla-central/search?q=blackbox&path=devtools%2Fclient%2Flocales%2Fen-US%2Fdebugger.properties

Blackbox source → Ignore source
Unblackbox source → Unignore source
…

A follow-up bug should handle the source renaming, which needs to be balanced with protocol breaking changes.

Comment 1

[Sebastian Zartner [:sebo]]

When it's renamed, the documentation related to it needs to be adjusted accordingly.

The places where I saw it being mentioned are:

• https://developer.mozilla.org/en-US/docs/Tools/Debugger/UI_Tour
• https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to
• https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Black_box_a_source (needs a general update)
• https://developer.mozilla.org/en-US/docs/Tools/Debugger/Set_event_listener_breakpoints
• https://developer.mozilla.org/en-US/docs/Tools/Debugger/Settings (needs a general update)

Sebastian

Comment 2

[Richard Sherman :rich :richorrichard]

Attachment: Bug 1642811 - Rename UI references of "blacklist" to "ignore" in Debugger r=jlast!

Removed UI references to blacklist, replaced with ignore. Also updated the shortcut key to 'I' instead of 'D' since it's no longer Blacklist. Lastly updated tests to fix failing snapshot tests and jest tests.

Comment 3

[:Harald Kirschner :digitarald]

Janet,

since the current blackboxing docs are not the most read articles anyways, it seems we could update the docs right now: https://www.google.com/search?client=firefox-b-1-d&q=%28blackbox+or+blackboxing%29+site%3Adeveloper.mozilla.org%2Fen-US%2Fdocs%2FTools%2F

What do you think?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70a4c6e9cf6e
Rename UI references of "blacklist" to "ignore" in Debugger r=jlast,flod

Comment 5

[:Harald Kirschner :digitarald]

Canceling ni, cmills mentioned that language updates are already happening.

Comment 6

[Janet Swisher]

I'm replacing "black list" on MDN, but haven't done anything with "black box". To me, "black box" does not have the same negative connotation as "black list". I'm open to suggestions for rewording, though.

Comment 7

[:Harald Kirschner :digitarald]

I'm open to suggestions for rewording, though.

The new verb that landed with this patch is "ignore".

Comment 8

[Janet Swisher]

(In reply to :Harald Kirschner :digitarald from comment #7)

The new verb that landed with this patch is "ignore".

That's fine for "black list". Your link in Comment 3 was for "black box". That's what I was asking for alternatives for.

Comment 9

[:Harald Kirschner :digitarald]

Right, we did mix those up in the issue name – my bad. "Ignore source" is the new name for "Blackbox source".

Comment 10

[Richard Sherman :rich :richorrichard]

Oh shoot – that was my mistake in the commit message. Sorry for the confusion!

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/70a4c6e9cf6e

Comment 12

[Janet Swisher]

Updated the articles listed in comment #11, except Settings, which I moved into the "Archive" area of MDN, because it's obsolete and not referenced from anywhere else (that I found).