Closed Bug 1642852 Opened 5 years ago Closed 5 years ago

Add section in the "getting started/you might not need to rebuild" detailing how to work with workers

Categories

(DevTools :: Documentation, defect, P3)

defect

Tracking

(firefox80 fixed)

RESOLVED FIXED
Firefox 80
Tracking Status
firefox80 --- fixed

People

(Reporter: mburu.samuel, Assigned: soniasingla)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

  1. Opened a file under src/workers/ folder
  2. Added some console.log statements to said file
  3. Saved my changes
  4. Used Nightly UI to "Restart (Developer)"

Actual results:

After saving and using the "Restart (Developer)" in Nightly as suggested in the getting started docs, the browser did not load my latest changes.

Nor did they show up after I performed a manual stopping of the running Nightly instance provided ./mach run and performing another rebuild via ./mach build faster.

Expected results:

The changes should have appeared, console logs should have shown up in the Browser Console

A possible fix would be adding something like this below the "maybe you don't even need to build" section

#### Updating `worker` code requires a few extra steps
##### Prequisites
1. Install yarn 1.x globally via `npm install -g yarn` if you do not have it installed globally already
2. Go to the `client/debugger/` directory
3. Run `npm install`

##### Regenerating your worker bundle
1. Save your worker file changes
2. Back in your terminal in the `client/debugger/` directory execute `node bin/build`
3. After completion use the `Restart (Developer)` option in the `File` menu noted in the section above
Keywords: good-first-bug

I am working on this bug.

Under the section, Maybe you don’t even need to build should I totally remove everything and add the content as per the above comment? or make two cases :

  1. As per above comment
  2. As given in the (getting started docs)[https://firefox-source-docs.mozilla.org/devtools/getting-started/build.html#maybe-you-don-t-even-need-to-build]
Flags: needinfo?(odvarko)

Yes, I think we should remove the entire section
https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/devtools/docs/getting-started/build.md#147-167
(including the restart.png file)

Honza

Flags: needinfo?(odvarko)
Assignee: nobody → soniasingla.1812

The severity field is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(odvarko)
Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e26f96d32681 Adding section in getting started page. r=Honza
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
Severity: -- → S3
Flags: needinfo?(odvarko)
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: