Add section in the "getting started/you might not need to rebuild" detailing how to work with workers
Categories
(DevTools :: Documentation, defect, P3)
Tracking
(firefox80 fixed)
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: mburu.samuel, Assigned: soniasingla)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:76.0) Gecko/20100101 Firefox/76.0
Steps to reproduce:
- Opened a file under
src/workers/
folder - Added some console.log statements to said file
- Saved my changes
- Used Nightly UI to "Restart (Developer)"
Actual results:
After saving and using the "Restart (Developer)" in Nightly as suggested in the getting started docs, the browser did not load my latest changes.
Nor did they show up after I performed a manual stopping of the running Nightly instance provided ./mach run
and performing another rebuild via ./mach build faster
.
Expected results:
The changes should have appeared, console logs should have shown up in the Browser Console
Reporter | ||
Comment 1•5 years ago
|
||
A possible fix would be adding something like this below the "maybe you don't even need to build" section
#### Updating `worker` code requires a few extra steps
##### Prequisites
1. Install yarn 1.x globally via `npm install -g yarn` if you do not have it installed globally already
2. Go to the `client/debugger/` directory
3. Run `npm install`
##### Regenerating your worker bundle
1. Save your worker file changes
2. Back in your terminal in the `client/debugger/` directory execute `node bin/build`
3. After completion use the `Restart (Developer)` option in the `File` menu noted in the section above
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
I am working on this bug.
Under the section, Maybe you don’t even need to build
should I totally remove everything and add the content as per the above comment? or make two cases :
- As per above comment
- As given in the (getting started docs)[https://firefox-source-docs.mozilla.org/devtools/getting-started/build.html#maybe-you-don-t-even-need-to-build]
Assignee | ||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Yes, I think we should remove the entire section
https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/devtools/docs/getting-started/build.md#147-167
(including the restart.png file)
Honza
Assignee | ||
Comment 4•5 years ago
|
||
Updated•5 years ago
|
Comment 5•5 years ago
|
||
The severity field is not set for this bug.
:Honza, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 7•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•