Closed Bug 1642878 Opened 11 months ago Closed 6 months ago

Right click on text in search box brings up incomplete context menu

Categories

(Firefox :: Search, defect, P4)

77 Branch
Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox81 --- wontfix
firefox82 --- wontfix
firefox83 --- fixed

People

(Reporter: metaxaos, Assigned: tanner.drake)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Attached image Incomplete context menu

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

  1. open new tab with empty page
  2. click search box, type in some text
  3. click somewhere on the empty page
  4. right click on the search box (doesn't matter, text or empty space)
    NOTE: It seems that the issue only appears on MacOS. Broken since (approximately) v75.

Actual results:

Text in search box becomes selected, text context menu appears with options "cut", "copy" and "delete" inactive. In order to make them active you need to right-click the selected text in search box again.

Expected results:

Text in search box becomes selected, text context menu has options "cut", "copy" and "delete" active right away.

Attached image Complete context menu
Component: Untriaged → Search
OS: Unspecified → macOS
Severity: -- → S4
Priority: -- → P4

Hello! I have managed to find a regression for this issue.
Here is the pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f8ec5d8b4718a6456446b56c40ea32c50c631d48&tochange=ea48938d4cf677c4e00e093c2c92d7da5b52b0eb

Status: UNCONFIRMED → NEW
QA Whiteboard: [qa-regression-triage]
Ever confirmed: true

Bug 1612122 looks like a likely candidate, as that touched these menu options (and was trying to fix a previous regression).

Regressed by: 1612122

Do we need to update tracking flags? It's FF 80 already but haven't fixed yet.

(In reply to metaxaos from comment #4)

Do we need to update tracking flags? It's FF 80 already but haven't fixed yet.

No, the fact that it the bug is open is enough to track it. Note that this is fairly low priority relative to the rest of our work at the moment.

I believe I've got a patch for this if someone can assign it to me.

You can submit patches via phabricator and it will then automatically assign the bug to you.

Got it, thanks Mark!
side note, I was able to reproduce this outside of Mac OS X on Linux (Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0)

Assignee: nobody → tanner.drake
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tanner.drake, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(tanner.drake)
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46674947023c
update context menu items disabled states after _maybeSelectAll in contextmenu open. r=Standard8

I'd missed that this hadn't landed - so I've just triggered that process. In future, you can add a "checkin-needed" tag on the revision in phabricator.

Thank you for working on this Tanner.

Flags: needinfo?(tanner.drake)
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 83 Branch
You need to log in before you can comment on or make changes to this bug.