1642878 - Right click on text in search box brings up incomplete context menu

Status: RESOLVED FIXED

(Firefox :: Search, defect, P4)

Description

[metaxaos]

Attachment: Incomplete context menu

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:76.0) Gecko/20100101 Firefox/76.0

Steps to reproduce:

1. open new tab with empty page
2. click search box, type in some text
3. click somewhere on the empty page
4. right click on the search box (doesn't matter, text or empty space)
   NOTE: It seems that the issue only appears on MacOS. Broken since (approximately) v75.

Actual results:

Text in search box becomes selected, text context menu appears with options "cut", "copy" and "delete" inactive. In order to make them active you need to right-click the selected text in search box again.

Expected results:

Text in search box becomes selected, text context menu has options "cut", "copy" and "delete" active right away.

Comment 1

[metaxaos]

Attachment: Complete context menu

Comment 2

[Negritas Sergiu, Desktop QA]

Hello! I have managed to find a regression for this issue.
Here is the pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f8ec5d8b4718a6456446b56c40ea32c50c631d48&tochange=ea48938d4cf677c4e00e093c2c92d7da5b52b0eb

Comment 3

[Mark Banner (:standard8)]

Bug 1612122 looks like a likely candidate, as that touched these menu options (and was trying to fix a previous regression).

Comment 4

[metaxaos]

Do we need to update tracking flags? It's FF 80 already but haven't fixed yet.

Comment 5

[Mark Banner (:standard8)]

(In reply to metaxaos from comment #4)

Do we need to update tracking flags? It's FF 80 already but haven't fixed yet.

No, the fact that it the bug is open is enough to track it. Note that this is fairly low priority relative to the rest of our work at the moment.

Comment 6

[Tanner Drake]

I believe I've got a patch for this if someone can assign it to me.

Comment 7

[Mark Banner (:standard8)]

You can submit patches via phabricator and it will then automatically assign the bug to you.

Comment 8

[Tanner Drake]

Got it, thanks Mark!
side note, I was able to reproduce this outside of Mac OS X on Linux (Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Firefox/82.0)

Comment 9

[Tanner Drake]

Attachment: Bug 1642878 - update context menu items disabled states after _maybeSelectAll in contextmenu open.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:tanner.drake, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46674947023c
update context menu items disabled states after _maybeSelectAll in contextmenu open. r=Standard8

Comment 12

[Mark Banner (:standard8)]

I'd missed that this hadn't landed - so I've just triggered that process. In future, you can add a "checkin-needed" tag on the revision in phabricator.

Thank you for working on this Tanner.

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/46674947023c