1642915 - [MIPS] Add byte swap instructions.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Zhao Jiazhong]

D74620 added byte swap instructions to the assemblers on arm and x86 platforms, which also needs to be implemented on mips.

Comment 1

[Zhao Jiazhong]

Attachment: Bug 1642915 - [MIPS] Add byte swap instructions to the assemblers. r=tcampbell.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d20ce0e9174d
[MIPS] Add byte swap instructions to the assemblers. r=tcampbell.

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d20ce0e9174d

Comment 4

[Zhao Jiazhong]

Comment on attachment 9154471 [details]
Bug 1642915 - [MIPS] Add byte swap instructions to the assemblers. r=tcampbell.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This bug caused both some tests and real world websites like youtube crash on mips platform.
• User impact if declined: On mips platform, some websites like youtube may crash.
• Fix Landed on Version: 79
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change only affects mips platform and has been landed in ff79 for a long time.
• String or UUID changes made by this patch:

Comment 5

[Zhao Jiazhong]

This ESR uplift request is related with bug 1696838.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9154471 [details]
Bug 1642915 - [MIPS] Add byte swap instructions to the assemblers. r=tcampbell.

This doesn't graft cleanly to ESR78. Please attach a rebased patch for uplift.

Comment 7

[Zhao Jiazhong]

Attachment: Bug 1642915 - [MIPS] Add byte swap instructions to the assemblers. r=tcampbell, a=RyanVM

Comment 8

[Zhao Jiazhong]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Comment on attachment 9154471 [details]
Bug 1642915 - [MIPS] Add byte swap instructions to the assemblers. r=tcampbell.

This doesn't graft cleanly to ESR78. Please attach a rebased patch for uplift.

Hi, is it like this? Do I need to start a new revision? Thanks!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9207686 [details] [diff] [review]
Bug 1642915 - [MIPS] Add byte swap instructions to the assemblers. r=tcampbell, a=RyanVM

Perfect, thanks! Approved for 78.9esr.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/2a9ef7b1974d