1642949 - Avoid suboptimal uses of nsTArray::RemoveElementAt when removing the last element

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Simon Giesecke [:sg] [he/him]]

Uses of nsTArray::RemoveElementAt where the element index is known to be the last one should better use nsTArray::RemoveLastElement, which is more optimal. In cases where the last element needs to be accessed at the same time, nsTArray::PopLastElement should be used.

(Actually, this is a reinstantiation of Bug 1445302)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1642949 - Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=#xpcom-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c827da9d847
Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj

Comment 3

[Atila Butkovits]

Backed out for causing failure at test_headless_screenshot.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0ca9f1ff7aacca2aed2a74a4c6743a02eed9917f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=98c420f7338066f5e4fe35fbce9905911e895efd&selectedTaskRun=V3VbtT7VRv6OzmxesaPA_w-0

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305754090&repo=autoland&lineNumber=1408

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/127b5f65cf50
Replace uses of RemoveElementAt by RemoveLastElement/PopLastElement where possible. r=necko-reviewers,froydnj

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/127b5f65cf50