1642952 - Try to avoid needing to have separate rebuild cache / load cache flows

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Currently, various items trigger rebuilding the search engine cache instead of simply loading it.

With the recent changes for the modern configuration, the workflows between rebuild and loading are pretty much exactly the same. This should be clearer once bug 1642391 is completed.

We should therefore look at simplifying it down to one flow.

When we do this, we should keep an eye out for possible issues with OpenSearch based engines.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1642952 - Modern search engine configuration no longer needs to 'rebuild' the cache on startup. r?daleharvey!

For the modern configuration, the rebuild and non-rebuild cache paths are virtually identical - we now load the app-provided engines, then the user engines. The non-rebuild cache route also applies WebExtensions found by the add-on manager whilst we're starting up, but we can apply that to the rebuild cache route as well.

Comment 2

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb7f705a5e0782795bde20451afca3c82255b87e&selectedTaskRun=Bv08Hs6rRjWS7xhFwBHtDA.0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6149194bac8d
Modern search engine configuration no longer needs to 'rebuild' the cache on startup. r=daleharvey

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6149194bac8d