1643003 - [RTL] The background gradient color of the `.monitor-blocks` is facing the wrong way

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P2)

Description

[Itiel]

Attachment: Screenshot

Related code:
https://searchfox.org/mozilla-central/rev/559b25eb41c1cbffcb90a34e008b8288312fcd25/browser/components/protections/content/protections.css#837,842,847

Comment 1

[Itiel]

Attachment: Bug 1643003 - Fix the gradient color direction of the monitor blocks for RTL r?ewright

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf239f5dad7a
Fix the gradient color direction of the monitor blocks for RTL r=ewright

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cf239f5dad7a

Comment 4

[Oana Botisan, Desktop QA]

I verified the fix on latest Nightly 80.a1 and Firefox 79.0b2 with the ar locale and the gradient is reversed from the image in comment 0. But I can't see the difference from the en-US build. The gradient is in the same direction in the ar and an-US builds. Is that expected?

Comment 5

[Itiel]

(In reply to Oana Botisan, Desktop Release QA from comment #4)

I verified the fix on latest Nightly 80.a1 and Firefox 79.0b2 with the ar locale and the gradient is reversed from the image in comment 0. But I can't see the difference from the en-US build. The gradient is in the same direction in the ar and an-US builds. Is that expected?

For me I see the monitored emails block the lightest in color, and the exposed passwords block the darkest, no matter which build I'm on (i.e. for LTR the direction is left-to-right (light to dark) and for RTL it's right-to-left (again, light to dark).
Is this not what you're seeing?

Comment 6

[Oana Botisan, Desktop QA]

Attachment: Screenshot_10.png

This is what I see, but for some reason the page is not translated. Or are you using another link than this: https://monitor.firefox.com/user/dashboard?utm_source=monitor.firefox.com?

Comment 7

[Itiel]

(In reply to Oana Botisan, Desktop Release QA from comment #6)

Created attachment 9160863 [details]
Screenshot_10.png

This is what I see, but for some reason the page is not translated. Or are you using another link than this: https://monitor.firefox.com/user/dashboard?utm_source=monitor.firefox.com?

Ah, I see now where the confusion is from.
This bug is about this same UI in about:protections, not in the Monitor website.

Comment 8

[Oana Botisan, Desktop QA]

I can't see a difference between the affected build (Nightly 2020-06-02) and the latest Nightly 80.a1. But the gradient is as in comment 5, the monitored emails block the lightest in color, and the exposed passwords block the darkest from right-to-left. This is the expected result, right?

Comment 9

[Itiel]

Yes.

Comment 10

[Oana Botisan, Desktop QA]

Then according to comment 8 and comment 9 I will mark this issue as verified fixed.