1643025 - [wpt-sync] Sync PR 23946 - Iterate sorted keys when comparing keyframes for testing

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23946 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23946
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

Iterate sorted keys when comparing keyframes for testing

Since enumeration does not guarantee any specific order, we can get
test failures when the order changes for an unrelated reason
(typically when adding a new CSS property).

Fix by sorting the keys before comparing, which ensures that we fail
the same way every time.

Change-Id: I7bbc8e98bc17120084c6934d71f092ee0ba016da
Reviewed-on: https://chromium-review.googlesource.com/2228724
WPT-Export-Revision: 325b700a48bfd92cb52daf47de2c31da9d247543

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=dec450f5d92ff7c55596a441e93d84e0b135045c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 30 tests and 2 subtests

Status Summary

Firefox

OK : 30
PASS : 723
FAIL : 17

Chrome

OK : 30
PASS : 693
FAIL : 47

Safari

OK : 29
PASS : 661
FAIL : 78
TIMEOUT: 2

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-logical/animation-001.html
Physical shorthands win over logical shorthands: FAIL linked bug:Bug 1520069
Physical shorthands using variables win over logical shorthands: FAIL linked bug:Bug 1520069
/web-animations/interfaces/Animatable/animate.html
animate() with pseudoElement parameter creates an Animation object for ::first-line: FAIL

New Tests That Don't Pass

/css/css-animations/Document-getAnimations.tentative.html
CSS Animations targetting (pseudo-)elements should have correct order after sorting (::marker): FAIL (Chrome: PASS, Safari: FAIL)
/css/css-logical/animation-001.html
Logical shorthands follow the usual prioritization based on number of component longhands: FAIL (Chrome: FAIL, Safari: FAIL)
Physical shorthands win over logical shorthands: FAIL (Chrome: PASS, Safari: PASS)
Physical shorthands using variables win over logical shorthands: FAIL (Chrome: PASS, Safari: PASS)
/web-animations/interfaces/KeyframeEffect/constructor.html
A KeyframeEffect can be constructed with a property-indexed keyframes specification with a CSS variable as the property: FAIL (Chrome: PASS, Safari: FAIL)
A KeyframeEffect can be constructed with a two property (one shorthand and one of its shorthand components) two value property-indexed keyframes specification: FAIL (Chrome: PASS, Safari: FAIL)
A KeyframeEffect can be constructed with a keyframe sequence with a CSS variable as its property: FAIL (Chrome: PASS, Safari: FAIL)
/web-animations/interfaces/KeyframeEffect/setKeyframes.html
Keyframes can be replaced with a keyframe sequence with a CSS variable as its property: FAIL (Chrome: PASS, Safari: FAIL)
Keyframes can be replaced with a two property (one shorthand and one of its shorthand components) two value property-indexed keyframes specification: FAIL (Chrome: PASS, Safari: FAIL)
Keyframes can be replaced with a property-indexed keyframes specification with a CSS variable as the property: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-animations/event-order.tentative.html
Same events on pseudo-elements follow the prescribed order (::marker): FAIL (Chrome: PASS, Safari: FAIL)
/web-animations/interfaces/Animatable/animate.html
animate() with pseudoElement an Animation object targeting the correct pseudo-element for ::first-line: FAIL (Chrome: PASS, Safari: FAIL)
Element.animate() correctly sets the Animation's timeline with null timeline in KeyframeAnimationOptions.: FAIL (Chrome: FAIL, Safari: FAIL)
Element.animate() accepts a keyframe sequence with a CSS variable as its property: FAIL (Chrome: PASS, Safari: FAIL)
Element.animate() accepts a property-indexed keyframes specification with a CSS variable as the property: FAIL (Chrome: PASS, Safari: FAIL)
animate() with pseudoElement parameter creates an Animation object for ::first-line: FAIL (Chrome: PASS, Safari: PASS)
Element.animate() accepts a two property (one shorthand and one of its shorthand components) two value property-indexed keyframes specification: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d49f049f1f0
[wpt PR 23946] - Iterate sorted keys when comparing keyframes for testing, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2a71ae6a1739
[wpt PR 23946] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2d49f049f1f0
https://hg.mozilla.org/mozilla-central/rev/2a71ae6a1739