1643129 - HTTP auth prompting busted

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

From Fenix issue https://github.com/mozilla-mobile/fenix/issues/8969

It looks like we aren't handling http auth prompts correctly in GV.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

06-03 14:27:19.010 3984 4000 E GeckoConsole: [JavaScript Error: "TypeError: can't access property "ensureDataReady", this._store is undefined" {file: "resource://gre/modules/storage-json.js" line: 645}]
06-03 14:27:19.010 3984 4000 E GeckoConsole: countLogins@resource://gre/modules/storage-json.js:645:5
06-03 14:27:19.010 3984 4000 E GeckoConsole: countLogins@resource://gre/modules/LoginManager.jsm:512:26
06-03 14:27:19.010 3984 4000 E GeckoConsole: _doAsyncPrompt@resource://gre/modules/LoginManagerAuthPrompter.jsm:158:37
06-03 14:27:19.010 3984 4000 E GeckoConsole: asyncPromptAuth@resource://gre/modules/LoginManagerAuthPrompter.jsm:877:21
06-03 14:27:19.010 3984 4000 E GeckoConsole: [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "can't access property "ensureDataReady", this._store is undefined" {file: "resource://gre/modules/storage-json.js" line: 645}]'[JavaScript Error: "can't access property "ensureDataReady", this._store is undefined" {file: "resource://gre/modules/storage-json.js" line: 645}]' when calling method: [nsILoginManagerStorage::countLogins]" {file: "resource://gre/modules/LoginManager.jsm" line: 512}]

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1643129 - Skip countLogins calls in _doAsyncPrompt if the MP isn't currently showing. r=#geckoview-reviewers

Comment 3

[Matthew N. [:MattN]]

I attached an untested patch that should fix the issue. Someone else can take over to write tests and verify it works.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1643129 - Add a reload to GV auth prompt test

This is needed in order to catch certain problems with LoginStorage.jsm.

Comment 6

[Matthew N. [:MattN]]

The two findLogins calls in LoginManagerAuthPrompter.jsm probably also need to be replaced with searchLoginsAsync if you want saved logins to be filled into HTTP auth prompts. Perhaps that can be done in a separate bug if this one is sufficient to unbreak the dialogs.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ba8b78124a9
Skip countLogins calls in _doAsyncPrompt if the MP isn't currently showing. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/b746ee53bfe9
Add a reload to GV auth prompt test r=geckoview-reviewers,aklotz

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9ba8b78124a9
https://hg.mozilla.org/mozilla-central/rev/b746ee53bfe9