1643130 - Update disabled-pause button to clearer style

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[:Harald Kirschner :digitarald]

When pausing is disabled, the UI state should clearly communicate it to users.

The final spec is in this comment: https://github.com/firefox-devtools/ux/issues/125#issuecomment-631046721

Comment 1

[DH Kim]

Hi, Harald. I was following this issue on Github, and I wanted to tell you that I'd like to claim this one :)

I actually had a question for you: by final spec, do you also mean that you want the contributor to use one of Victoria's design? They look great, but I wasn't sure if you wanted the contributor to come up with his/her own.

Comment 2

[:Harald Kirschner :digitarald]

Hi DH Kim, thank yiu, you are assigned.

The goal would be to use the final decision from the UX issue. If you have ideas though, feel free to share them in the UX issue or prototype them out in patches if that is easier.

Comment 3

[Victoria Wang [:victoria]]

Todo for me - clean up vector and add to this bug.

Comment 4

[Victoria Wang [:victoria]]

Attachment: debugger disable fill.svg

Hi! Sorry all for the delay.

I'm attaching two SVGs here. Let me know if there are any issues.

Comment 5

[Victoria Wang [:victoria]]

Attachment: debugger disable.svg

Comment 6

[DH Kim]

Thank you, Victoria. And Harald, I'll make a patch w/ Victoria's design reflected therein.

Comment 7

[DH Kim]

Attachment: Bug 1643130 - Update disabled-pause button with clearer style

Comment 8

[DH Kim]

Attachment: Bug 1643130 - Include enabled-pause button with clearer style

Depends on D81790

Comment 9

[DH Kim]

Attachment: Bug 1643130 - Add relevant svg asset

Depends on D81814

Comment 10

[DH Kim]

In retrospect I should have rolled everything under one commit message, so my apologies!

PS: I wasn't sure what the scope of the linked issue entailed. The three differentials together simply replace the current disable SVG asset with the new ones that Victoria designed. Nothing more!

Comment 11

[DH Kim]

Attachment: Bug 1643130 - Update disabled pause button style

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0f644cd91be
Update disabled pause button style r=Harald,loganfsmyth

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a0f644cd91be