Closed Bug 1643130 Opened 2 months ago Closed 1 month ago

Update disabled-pause button to clearer style

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox80 fixed)

RESOLVED FIXED
Firefox 80
Tracking Status
firefox80 --- fixed

People

(Reporter: Harald, Assigned: icncsx)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(3 files, 3 obsolete files)

When pausing is disabled, the UI state should clearly communicate it to users.

The final spec is in this comment: https://github.com/firefox-devtools/ux/issues/125#issuecomment-631046721

Hi, Harald. I was following this issue on Github, and I wanted to tell you that I'd like to claim this one :)

I actually had a question for you: by final spec, do you also mean that you want the contributor to use one of Victoria's design? They look great, but I wasn't sure if you wanted the contributor to come up with his/her own.

Flags: needinfo?(hkirschner)

Hi DH Kim, thank yiu, you are assigned.

The goal would be to use the final decision from the UX issue. If you have ideas though, feel free to share them in the UX issue or prototype them out in patches if that is easier.

Assignee: nobody → icncsx
Flags: needinfo?(hkirschner)

Todo for me - clean up vector and add to this bug.

Flags: needinfo?(victoria)

Hi! Sorry all for the delay.

I'm attaching two SVGs here. Let me know if there are any issues.

Flags: needinfo?(victoria)

Thank you, Victoria. And Harald, I'll make a patch w/ Victoria's design reflected therein.

Attachment #9160535 - Attachment is obsolete: true
Attachment #9160535 - Attachment is obsolete: false

Depends on D81790

Attached file Bug 1643130 - Add relevant svg asset (obsolete) —

Depends on D81814

In retrospect I should have rolled everything under one commit message, so my apologies!

PS: I wasn't sure what the scope of the linked issue entailed. The three differentials together simply replace the current disable SVG asset with the new ones that Victoria designed. Nothing more!

Attachment #9160585 - Attachment is obsolete: true
Attachment #9160583 - Attachment is obsolete: true
Attachment #9160535 - Attachment is obsolete: true
Pushed by loganfsmyth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a0f644cd91be
Update disabled pause button style r=Harald,loganfsmyth
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 80
You need to log in before you can comment on or make changes to this bug.