1643168 - AXFocusable should only be settable on focusable items.

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Eitan Isaacson [:eeejay]]

The selector name we use in moxBlockSelector is wrong, so we end up marking all accessibles as focusable.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Bug 1643168 - block moxSetFocused: on non-focusable accessibles. r?morgan

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1641644

Comment 3

[Marco Zehe (:MarcoZ)]

Eitan, when you land this, please also request uplift to beta because this is a regression we introduced in 78. And even though we haven't officially announced anything, we shouldn't regress people even now. And this looks like a low enough risk patch to me.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/498dee65dcf8
block moxSetFocused: on non-focusable accessibles. r=morgan

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 498dee65dcf8 (bug 1643168) for Browser-chrome failures browser/mac/browser_focus.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305497159&repo=autoland&lineNumber=1182

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=498dee65dcf8100e2346323a89cb2e32d3c9e524

Backout:
https://hg.mozilla.org/integration/autoland/rev/4a03c972dd3927787f2562368167a195e3b4efc3

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1a4115fe0fe
block moxSetFocused: on non-focusable accessibles. r=morgan

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c1a4115fe0fe

Comment 8

[Ryan VanderMeulen [:RyanVM]]

(In reply to Marco Zehe (:MarcoZ) from comment #3)

Eitan, when you land this, please also request uplift to beta because this is a regression we introduced in 78. And even though we haven't officially announced anything, we shouldn't regress people even now. And this looks like a low enough risk patch to me.

Looks like this missed the boat for Fx78 :-(. Do we want this on ESR78 still?

Comment 9

[Marco Zehe (:MarcoZ)]

Yes, this was a pretty major refactor, and since 78 ESR will be around for a while, we should take this.

Comment 10

[Marco Zehe (:MarcoZ)]

Comment on attachment 9153988 [details]
Bug 1643168 - block moxSetFocused: on non-focusable accessibles. r?morgan

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: For assistive technologies on the Mac, after the regressing bug, every item appears focusable. This can have unwanted side effects in many areas.
• User impact if declined: VoiceOver and other accessibility features will treat every element on a web page as focusable even when it isn't.
• Fix Landed on Version: 79
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just corrects an exposed attribute value.
• String or UUID changes made by this patch: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9153988 [details]
Bug 1643168 - block moxSetFocused: on non-focusable accessibles. r?morgan

Improves the a11y experience for macOS users. Approved for 78.1esr.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/b33a6cbaeddb