1643169 - media/mtransport/third_party/nICEr/src/stun/addrs-bsd.c:43:18: error: subscripted value is not an array, pointer, or vector

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Jan Beich]

$ c++ --version
FreeBSD clang version 10.0.1 ([e-mail]:llvm/llvm-project.git llvmorg-10.0.1-rc1-0-gf79cd71e145)
Target: x86_64-unknown-freebsd13.0
Thread model: posix
InstalledDir: /usr/bin

$ ./mach bootstrap
$ ./mach build
[...]
In file included from Unified_c_third_party_nICEr1.c:11:
media/mtransport/third_party/nICEr/src/stun/addrs-bsd.c:43:18: error: subscripted value is not an array, pointer, or vector
    flags = ifr6.ifr_flags;
            ~~~~~^~~~~~~~~
/usr/include/net/if.h:419:38: note: expanded from macro 'ifr_flags'
#define ifr_flags       ifr_ifru.ifru_flags[0]  /* flags (low 16 bits) */
                                           ^~
1 error generated.

Either ifr_ifru.ifru_flags or ifr_ifru.ifru_flags6 works but not ifr_flags alias.
See also https://searchfox.org/mozilla-central/rev/7cadba1d8b8f/media/webrtc/trunk/webrtc/rtc_base/macifaddrs_converter.cc#221

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Byron, would you mind taking a look?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1183145

Comment 3

[Byron Campen [:bwc]]

On it.

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1643169: Use ifr_ifru.ifru_flags6 instead of the ifr_flags macro, because the latter does not work properly on FreeBSD. r?mjf

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08317d99e57a9a2e7fc8d253485fb10190ae46d3

Gtest: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b91585f1cfe2934f9499db2bb30703ab40de0182

Comment 6

[Byron Campen [:bwc]]

Check back on try.

Comment 7

[Byron Campen [:bwc]]

Try looks good.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/592a83b0c9de
Use ifr_ifru.ifru_flags6 instead of the ifr_flags macro, because the latter does not work properly on FreeBSD. r=mjf

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/592a83b0c9de