Closed Bug 1643173 Opened 1 month ago Closed 1 month ago

Unify GetDisplayFlagsForFlexItem and GetDisplayFlagsForGridItem

Categories

(Core :: Layout, task)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(2 files)

While working on bug 1642694, I notice GetDisplayFlagsForFlexItem and GetDisplayFlagsForGridItem have identical implementation. Let's unify these two helpers.

I'll also convert DISPLAY_CHILD_* to enum class.

The modifications are all straightforward conversion except the one in
nsMathMLContainerFrame, where it is simplified by calling the equivalent
BuildDisplayListForInline() helper.

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9bea5add0bcd
Part 1 - Convert enum nsIFrame::DISPLAY_CHILD_* to enum class. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/382c1d654e26
Part 2 - Unify GetDisplayFlag helpers for flex and grid items. r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.