1643176 - runtime.sendMessage(badid, msg) = Error: can't access property "wakeupBackground", extension is undefined

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P3)

Description

[Rob Wu [:robwu]]

Attachment: sendResponse-bad-id.zip

STR:

1. Load the attached extension.
2. Open the global JS console or inspect the extension's background page at about:debugging.
3. Click the extension button.
4. Look at the console.

Expected:

• Firefox 78: Error : Could not establish connection. Receiving end does not exist.
• Chrome 83: Error in event handler: TypeError: Error in invocation of runtime.sendMessage(optional string extensionId, any message, optional object options, optional function responseCallback): Invalid extension id: 'SOME_BAD_ID'

Actual:

• Firefox 79: Error : can't access property "wakeupBackground", extension is undefined

There are two unexpected results here:

• The error message changed to something non-sensical (to extension devs).
• The internal error message from the browser process is leaked to extensions. At the very least it should have been "An unexpected error occurred", together with the actual error dumped to the global JS console, to be consistent with how we handle other unexpected errors in our extension API handlers.

To get a sensible error message, the error should be handled here: toolkit/components/extensions/ExtensionParent.jsm #321
plus a regression test at xpcshell/test_ext_runtime_sendMessage_args.js.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1583484

Comment 2

[Rob Wu [:robwu]]

This bug is similar to bug 1665568, to fix this bug a !extension check needs to be added as explained in the report above.

The leakage of the internal error message had been fixed in bug 1655624, now it's just "An unexpected error has occurred".

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1643176 - Reject ERROR_NO_RECEIVERS if target extension is not found. r?robwu!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f11243214c4
Reject ERROR_NO_RECEIVERS if target extension is not found. r=robwu

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3f11243214c4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:rpl, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.