1643205 - Navigator's share() must consume user activation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Marcos Caceres [:marcosc]]

When share() is called, "consume user activation" of Window.

Comment 1

[Marcos Caceres [:marcosc]]

Edgar, could you guide me a little bit here?

The spec says:

If |window| does not have [=transient activation=], return [=a promise rejected with=] with a {{"NotAllowedError"}} {{DOMException}}.

What's the equivalent in Gecko for checking "If window does not have transient activation"?

And then the spec says:

[=Consume user activation=] of |window|.

I assume I need to call UserActivation.StopHandlingUserInput()?

Comment 2

[Marcos Caceres [:marcosc]]

As an aside, as these are user activation stuff is pretty common in specs, what might be nice is to document these like:

• if the spec says, "consume", do this: ...
• if the spec says "sticky activation", do this: ...
• If the spec says "transient activation", do this: ...

The we have easy recipes to follow when implementing.

Comment 3

[Edgar Chen [:edgar]]

To check transient activation, you could use BrowsingContext::HasValidTransientUserGestureActivation(). And BrowsingContext::ConsumeTransientUserGestureActivation() is for consuming transient activation. We also provide some chrome only api on Document for testing purpose.

Comment 4

[Marcos Caceres [:marcosc]]

Amazing! Thanks Edgar!!!

Comment 5

[Marcos Caceres [:marcosc]]

Attachment: Bug 1643205 - Navigator's share() must consume user activation

navigator.share() must consume the user activation.

Comment 6

[Marcos Caceres [:marcosc]]

Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=30f744bbf7d020b5797d93c188160e4a42873047

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Should this wait for the PR to land first?

Comment 8

[Marcos Caceres [:marcosc]]

Will land them all together (the PR is approved and the google folks are onboard too).

Another try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e6a62dbd40d08125beff24cff2c9cca0a61d4f8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ff60304993b
Navigator's share() must consume user activation r=edgar

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24187 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Natalia Csoregi [:nataliaCs]]

Backed out for multiple failures

backout: https://hg.mozilla.org/integration/autoland/rev/c62bd67aecccdf8aa5b6336b5a71d537175cf34e

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9ff60304993b852e4a68e9ff1ee47f4f3054e697&group_state=expanded&selectedTaskRun=Qcw0dpsuQh2HIopKfyoFBg.0

failure logs:

• web-share/share-consume-activation.https.html https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306645644&repo=autoland&lineNumber=64416
• dom/webshare/test/mochitest/test_navigator_share_consume_user_activation.html https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=306639433&repo=autoland&lineNumber=1226

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Marcos Caceres [:marcosc]]

Ah, forgot to disable for Windows 😅

Comment 15

[Marcos Caceres [:marcosc]]

Try try try again (disabling for windows):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=90b7fd82b8f32c118ac6273123fc697d3f6c0400

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7cd5a26f98e
Navigator's share() must consume user activation r=edgar

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 18

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b7cd5a26f98e

Comment 19

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot