1643230 - CSS parser isn't reporting first error after good declaration

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[tustamido]

Given the following CSS code as example:
* { color: blue; abc; def; ghi; jkl; }

CSS parser should report 4 errors, as it happens when using W3C Validator: https://jigsaw.w3.org/css-validator/

Instead, Firefox reports only 3, it skips "abc;".

Code to reproduce (just paste it on Browser Console):

docShell.cssErrorReportingEnabled = true;
let errorListener = {
  observe: function (message) {
    let error = message.QueryInterface(Ci.nsIScriptError);
    console.log(error.errorMessage);
  }
};
Services.console.registerListener(errorListener);
let styleEl = document.createElement('style');
styleEl.appendChild(document.createTextNode('* { color: blue; abc; def; ghi; jkl; }'));
document.documentElement.appendChild(styleEl);

Using mozregression, mozilla-central 2019-05-08 was good (reports all 4 erros, including "abc;"), 2019-05-09 was bad. But I can't go deeper than this as it seems inbound/autoland builds are deleted after 365 days (am I right in this?).

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fd9b8188501938a9306105a01db5beeefeab1a19&tochange=2abcefb31ba7b2a1c573edc5695b772826c6a078

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think I can make an educated guess which of those caused the regression, though I didn't test.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah, I can probably take it anyhow. Thanks David :)

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1643230 - Clear last_parsed_property_id right after successfully parsing the value. r=#style

Rather than waiting until parsing another id (successfully or
unsuccessfully).

If we error before we even get to PropertyId::parse, we'd incorrectly
associate the error with the wrong property, incorrectly omitting it
sometimes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08748e5b0fd3
Clear last_parsed_property_id right after successfully parsing the value. r=jwatt

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/08748e5b0fd3

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Not really, long-standing issue.