Closed Bug 1643246 Opened 5 years ago Closed 5 years ago

down arrow symbol is missing in <select size=""> of HTML pages

Categories

(Core :: Layout: Form Controls, defect, P3)

Product:
Core
Component:
Layout: Form Controls
Version:
59 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox-esr68 --- wontfix
firefox-esr78 --- wontfix
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- wontfix
firefox80 --- verified

People

(Reporter: vamsee.aditya3, Assigned: heycam)

References

(Regression,
URL
)

Details

(Keywords: regression)

Attachments

(2 files)

firefox_Issue.png
39.10 KB, image/png
Details
Bug 1643246 - Don't use attribute selectors for determining if a select is a drop down or a list box.
47 bytes, text/x-phabricator-request
Details | Review
Attached image firefox_Issue.png —

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Firefox/77.0

Steps to reproduce:

create a select box like,
<html>
<body>
<select id="t" size="">
<option>1</option>
<option>2</option>
<option>3</option>
</select>
</body>
</html>

Actual results:

If the attribute size is empty, then arrow mark is missed. If the size is 1 or more then the arrow mark is displayed.

Expected results:

The arrow mark should be displayed if size is empty considering "1" as default.

<select size=""> does not show dropdown arrow

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1ce9b4193d624d5d4ed4bceecfbeb1514f818848&tochange=e61c4485494ec4823da22217f665d73858c57e35

Suspect:
981938848b0040e47de5289041bbcf27561baa4f Mats Palmgren — Bug 1246836 part 2 - Reftest. r=me
36be4f8806ce195b201299beb1af66200294e381 Mats Palmgren — Bug 1246836 part 1 - Render the <select> dropdown button for -moz-appearance:menulist only.

Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox76: --- → wontfix
status-firefox77: --- → wontfix
status-firefox78: --- → affected
status-firefox79: --- → affected
status-firefox-esr68: --- → wontfix
Component: Untriaged → Layout: Form Controls
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Regressed by: 1246836
See Also: → 1643279
Summary: down arrow symbol is missing in drop-down boxes of HTML pages → down arrow symbol is missing in <select size=""> of HTML pages
Version: 77 Branch → 59 Branch

Looks like we've been living with this regression for a while. Marking as S3.

Severity: -- → S3
status-firefox78: affected → wontfix
status-firefox79: affected → fix-optional
Priority: -- → P3

The rules we have in the UA sheets to match <select> elements that are drop downs don't match what the HTML spec says in terms of parsing of the size="" attribute, which is done using the rules for parsing non-negative integers. For example, we should be skipping white space, ignoring junk at the end of the number, etc.

The only way we can do exactly the right thing here is to add a new pseudo-class like :-moz-drop-down or :-moz-list-box, which parses size="" properly.

We already do something similar with :-moz-table-border-nonzero so it's not a big deal.

Assignee: nobody → cam
Status: NEW → ASSIGNED

Instead add a pseudo-class that does the expected size="" attribute parsing.

Removing the Gtk-specific rule setting the text color since it doesn't
seem to have any effect currently.

Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13062d9979d2 Don't use attribute selectors for determining if a select is a drop down or a list box. r=emilio

https://hg.mozilla.org/mozilla-central/rev/13062d9979d2

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Flags: qe-verify+

Reproduced the issue using Firefox 79.0a1 (20200603214922) on Windows 10x64.
The issue is verified fixed with Firefox 80.b1 (20200728204253) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.

Status: RESOLVED → VERIFIED
status-firefox80: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: