1643262 - Update vCard conversion to correctly handle multiple values of the same type

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

In most cases nsIAbCard only deals with one value of each type. Multiple values are allowed in a vCard for many data types. We need to ensure we use the right one, taking into account any preference given. For email addresses we can store two values, but there could be any number, so we need to handle that as best we can.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1643262-vcard-multiple-values-1.diff

This required a fairly big rethink of parsing. I've taken what was in vCardToAbCard and moved it to a separate function. It now returns a kind-of intermediate data structure that can also be reused in modifyVCard so that I didn't have to fix each problem twice.

I also renamed propertyMap to typeMap which is a better description, and converted the fromAbCard function to a generator since it can return multiple values in the case of email. toAbCard became a generator too since it can return 0-n values.

There's probably more corner cases I haven't thought of yet, and some things we just can't handle properly without virtually replacing nsIAbCard, but this makes me feel a lot better about our vCard functions.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9154104 [details] [diff] [review]
1643262-vcard-multiple-values-1.diff

Review of attachment 9154104 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4cec8714f352
Update vCard conversion to correctly handle multiple values of the same type. r=mkmelin

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9154104 [details] [diff] [review]
1643262-vcard-multiple-values-1.diff

Approved for beta

Comment 5

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/2b0b53861b61