1643270 - Arrays/Objects in the Response panel are not expandable

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:

1. Load http://janodvarko.cz/xhr-spy/
2. Open DevTools and select the Network panel
3. Click POST JSON With Array button
4. Select the request and open the Response panel
5. Try to collapse the arr array it doesn't work => BUG

ER: Expanding/collapsing works

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: image.png

Also, it might be related, the tree node indentation seems to be broken.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Bomsy, can you reproduce this one or it's just on my machine?

I see it in m-c only (not in Nightly), so could this be something recent?

Honza

Comment 3

[Hubert Boma Manilla (:bomsy)]

Yes I see it!
Looks like a regression, likely Bug 1639387

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1643270 - Isolate headers panel treeview css changes r=honza

• Fixes Bug 1643270 with unexpandale nodes
• Fixes Bug 1643296 so clicking any part of the method cllapses the node

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1639387

Comment 6

[:Harald Kirschner :digitarald]

Adding objects, as reported on matrix.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/051d7f284389
Isolate headers panel treeview css changes r=Honza

Comment 8

[Cristian Brindusan [:cbrindusan]]

Backed out 1 changesets (Bug 1643270) for devtools failures at browser_net_params_sorted.js.
https://hg.mozilla.org/integration/autoland/rev/227899eeb3a021bf81aa126760c20d20e36217b6

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=051d7f284389984a96a9b1ed58bb10ddb8a0b733&selectedTaskRun=YWLCVkqxSIeIcOIsFo1Oow-0

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305195024&repo=autoland&lineNumber=3910

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/535035537a93
Isolate headers panel treeview css changes r=Honza

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/535035537a93

Comment 11

[Hubert Boma Manilla (:bomsy)]

Comment on attachment 9154143 [details]
Bug 1643270 - Isolate headers panel treeview css changes r=honza

Beta/Release Uplift Approval Request

• User impact if declined: Impacts developers, Arrays in the Response panel are not expandable
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects developers , Small patch , Only few css changes
• String changes made/needed:

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 9154143 [details]
Bug 1643270 - Isolate headers panel treeview css changes r=honza

netmonitor regression fix, approved for 78.0b5

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c504d33b9ede