1643304 - Warp: fix try-catch support

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

Problem is that WarpBuilder skips the try-catch block but WarpOracle doesn't and aborts on the JSOp::Exception. For now the simplest fix is to add this to the list of supported ops and MOZ_CRASH in WarpBuilder.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1643304 - Properly support try-catch in Warp. r?iain!

WarpOracle was aborting on the JSOp::Exception. It's hard to (efficiently) skip
catch-blocks in WarpOracle too so this patch just adds it to the supported ops
and crashes in WarpBuilder since it's unreachable there.

This uncovered a few more test failures where we relied on specific exception messages.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e128b8f949f
Properly support try-catch in Warp. r=iain

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0e128b8f949f