1643333 - Factor code relevant for serializing nodes out from `nsDocumentEncoder`

Status: RESOLVED FIXED

(Core :: DOM: Serializers, enhancement)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Simplifies reasoning about nsDocumentEncoder, which has too many responsibilities.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1643333: part 1) const qualify argument of `IsInvisibleNodeAndShouldBeSkipped`. r=masayuki

Prepartory step for the following parts.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1643333: part 2) Document `nsDocumentEncoder::mFlags`. r=masayuki

Depends on D78308

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1643333: part 3) Change `IsInvisibleNodeAndShouldBeSkipped` to static method. r=masayuki

Will help to factor out functionality of serializing a node.

Depends on D78309

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1643333: part 4) Add `NodeSerializer`. r=masayuki

In separate reviews, SerializeNodeStart etc. will be moved to it.

Depends on D78310

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1643333: part 5) Move `SerializeNodeStart` and `SerializeNodeEnd` to `NodeSerializer`. r=masayuki

nsDocumentEncoder has too many responsibilities; this change
simplifies reasoning about it.

Depends on D78311

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1643333: part 6) Move `SerializeToStringIterative` to `NodeSerializer`. r=masayuki

Depends on D78312

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1643333: part 7) Move `SerializeToStringRecursive` to `NodeSerializer`. r=masayuki

Depends on D78313

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3578040c336
part 1) const qualify argument of `IsInvisibleNodeAndShouldBeSkipped`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/2c59ceb99ec4
part 2) Document `nsDocumentEncoder::mFlags`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/9193efaf7d9d
part 3) Change `IsInvisibleNodeAndShouldBeSkipped` to static method. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/a617ea1772f9
part 4) Add `NodeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/22656842192c
part 5) Move `SerializeNodeStart` and `SerializeNodeEnd` to `NodeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/c26ac7e8d49f
part 6) Move `SerializeToStringIterative` to `NodeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/5480197f2849
part 7) Move `SerializeToStringRecursive` to `NodeSerializer`. r=masayuki

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d3578040c336
https://hg.mozilla.org/mozilla-central/rev/2c59ceb99ec4
https://hg.mozilla.org/mozilla-central/rev/9193efaf7d9d
https://hg.mozilla.org/mozilla-central/rev/a617ea1772f9
https://hg.mozilla.org/mozilla-central/rev/22656842192c
https://hg.mozilla.org/mozilla-central/rev/c26ac7e8d49f
https://hg.mozilla.org/mozilla-central/rev/5480197f2849