Factor code relevant for serializing nodes out from `nsDocumentEncoder`
Categories
(Core :: DOM: Serializers, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
References
Details
Attachments
(7 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
Simplifies reasoning about nsDocumentEncoder, which has too many responsibilities.
|
Assignee | |
Comment 1•4 years ago
|
||
Prepartory step for the following parts.
|
|
Assignee | |
Comment 2•4 years ago
|
||
Depends on D78308
|
|
Assignee | |
Comment 3•4 years ago
|
||
Will help to factor out functionality of serializing a node.
Depends on D78309
|
|
Assignee | |
Comment 4•4 years ago
|
||
In separate reviews, SerializeNodeStart etc. will be moved to it.
Depends on D78310
|
|
Assignee | |
Comment 5•4 years ago
|
||
nsDocumentEncoder has too many responsibilities; this change
simplifies reasoning about it.
Depends on D78311
|
|
Assignee | |
Comment 6•4 years ago
|
||
Depends on D78312
|
|
Assignee | |
Comment 7•4 years ago
|
||
Depends on D78313
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d3578040c336 part 1) const qualify argument of `IsInvisibleNodeAndShouldBeSkipped`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/2c59ceb99ec4 part 2) Document `nsDocumentEncoder::mFlags`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/9193efaf7d9d part 3) Change `IsInvisibleNodeAndShouldBeSkipped` to static method. r=masayuki https://hg.mozilla.org/integration/autoland/rev/a617ea1772f9 part 4) Add `NodeSerializer`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/22656842192c part 5) Move `SerializeNodeStart` and `SerializeNodeEnd` to `NodeSerializer`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/c26ac7e8d49f part 6) Move `SerializeToStringIterative` to `NodeSerializer`. r=masayuki https://hg.mozilla.org/integration/autoland/rev/5480197f2849 part 7) Move `SerializeToStringRecursive` to `NodeSerializer`. r=masayuki
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/d3578040c336
https://hg.mozilla.org/mozilla-central/rev/2c59ceb99ec4
https://hg.mozilla.org/mozilla-central/rev/9193efaf7d9d
https://hg.mozilla.org/mozilla-central/rev/a617ea1772f9
https://hg.mozilla.org/mozilla-central/rev/22656842192c
https://hg.mozilla.org/mozilla-central/rev/c26ac7e8d49f
https://hg.mozilla.org/mozilla-central/rev/5480197f2849
Description
•