1643423 - Perma browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files: resource://gre/modules/jsdebugger.jsm referenced when Gecko 70 merges to Beta on 2020-06-29

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=FR2QiA1MTiymte6G9FGsIA-0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=7a1fa2203475625e35b446fe3d5ce79058f632be

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=305053829&repo=try

TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files: resource://gre/modules/jsdebugger.jsm referenced from resource://devtools/shared/worker/loader.js,resource://devtools/shared/builtin-modules.js -

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Masatoshi, Jason, please coordinate who will resolve this issue.

Comment 2

[Masatoshi Kimura [:emk]]

The removed code did not actually "refer" jsdebugger.jsm. checkAllTheFiles just scanned strings from libxul and misdetected the "reference".

Comment 3

[Masatoshi Kimura [:emk]]

In Nightly, remote/domains/content/Runtime.jsm refers jsdebugger.jsm.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Bug 1643423 - Whitelist jsdebugger.jsm when remote agent is disabled. r?jlast

We can't unship jsdebugger.jsm because Devtools are using it.

Comment 5

[Florian Quèze [:florian]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #0)

TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files: resource://gre/modules/jsdebugger.jsm referenced from resource://devtools/shared/worker/loader.js,resource://devtools/shared/builtin-modules.js -

This error says that it's resource://devtools/shared/worker/loader.js and resource://devtools/shared/builtin-modules.js that appear unreferenced. Why?

Comment 6

[Florian Quèze [:florian]]

Oh, the failure is only when running the test in non-devtools mode. Why is this devtools file located outside the devtools folder?

Comment 7

[Masatoshi Kimura [:emk]]

This file belongs to SpiderMonkey, so we can't move it from js/. Devtools happens to be the only non-test caller.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27cbaa46fea9
Whitelist jsdebugger.jsm when remote agent is disabled. r=loganfsmyth

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/27cbaa46fea9

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed in latest beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Crunnable&revision=41d33c6c9caa97604eb73694179e1ec0d5d426f7