Closed Bug 1643464 Opened 4 years ago Closed 4 years ago

Rename MouseEvent::eLeft/eRight as ePrimary/eSecondary

Categories

(Core :: Widget, task)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

Details

Attachments

(3 files)

https://searchfox.org/mozilla-central/rev/598e50d2c3cd81cd616654f16af811adceb08f9f/widget/EventForwards.h#441

eLeft not always refers to the left button and neither eRight. The terms "primary" and "secondary" better describe what they are.

Summary: Rename MousEvent::eLeft/eRight as ePrimary/eSecondary → Rename MouseEvent::eLeft/eRight as ePrimary/eSecondary
Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4c8047937892 Part 1: Rename eLeft/eRight to ePrimary/eSecondary r=masayuki https://hg.mozilla.org/integration/autoland/rev/9b9bb10684cf Part 2: Rename eLeft/eRightFlag to ePrimary/eSecondaryFlag r=masayuki,geckoview-reviewers,agi https://hg.mozilla.org/integration/autoland/rev/c165c77e4d24 Part 3: Rename LEFT/RIGHT_BUTTON as PRIMARY/SECONDARY_BUTTON r=masayuki,geckoview-reviewers,snorp
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: