1643528 - Cannot compile code with nss headers and -Werror=strict-prototypes

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Robert Relyea]

Attachment: nss-3.53-strict-proto-fix.patch

Description of problem:
The latest upgrade of nss broke compilation with -Werror=strict-prototypes

Version-Release number of selected component (if applicable):

How reproducible:
Deterministic

Steps to Reproduce:

1. dnf install -y gcc nss-devel
2. cat >test.c <<EOF
   #include <nss.h>
   #include <sechash.h>
   #include <pk11func.h>
   EOF
3. gcc pkg-config --cflags nss -c -Wstrict-prototypes -Werror=strict-prototypes test.c

Actual results:
sh-5.0$ gcc pkg-config --cflags nss -c -Wstrict-prototypes -Werror=strict-prototypes test.c
In file included from /usr/include/nss3/pk11func.h:12,
from test.c:3:
/usr/include/nss3/pk11pub.h:951:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
951 | int SECMOD_GetSystemFIPSEnabled();
| ^~~
cc1: some warnings being treated as errors
sh-5.0$ echo $?
1

Expected results:
sh-5.0$ gcc pkg-config --cflags nss -c -Wstrict-prototypes -Werror=strict-prototypes test.c
sh-5.0$ echo $?
0

Additional info:
Looks like it was newly added function.
sh-5.0$ grep -RniI SECMOD_GetSystemFIPSEnabled /usr/include/
sh-5.0$ rpm -q nss-devel
nss-devel-3.52.0-2.fc33.x86_64

And simple workaround is to run following command as root

sed -e '/SECMOD_GetSystemFIPSEnabled/s/();/(void);/' -i /usr/include/nss3/pk11pub.h

Comment 1

[Robert Relyea]

Comment on attachment 9154405 [details] [diff] [review]
nss-3.53-strict-proto-fix.patch

Forgot to put a reviewer up. It's a simple enough patch, but if you want me to go through the phabricator overhead I will.
bob

Comment 2

[Kevin Jacobs [:kjacobs]]

Comment on attachment 9154405 [details] [diff] [review]
nss-3.53-strict-proto-fix.patch

LGTM, thanks.

Comment 3

[Robert Relyea]

https://hg.mozilla.org/projects/nss/rev/01ffd8fef7fa187b3edbb6f92fbf6b4b78819a58