1643552 - browser_attendeesDialog.js failing on beta

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Geoff Lankow (:darktrojan)]

It looks like I've created something which works on ICAL.js but not libical. Now to figure out what.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1643552-libical-period-string.diff

The test is trying to do things like cal.createDuration("P-2D") which libical can't handle. I think somewhere in the distant past I've discovered that before.

Comment 2

[Magnus Melin [:mkmelin]]

Why is it beta specific?

Comment 3

[Paul Morris [:pmorris]]

Comment on attachment 9154453 [details] [diff] [review]
1643552-libical-period-string.diff

Review of attachment 9154453 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to Geoff Lankow (:darktrojan) from comment #1)

The test is trying to do things like cal.createDuration("P-2D") which libical can't handle. I think somewhere in the distant past I've discovered that before.

Is that valid at all? Should this be "-P2D"? According to https://tools.ietf.org/html/rfc5545#section-3.3.6 the duration format is:
dur-value = (["+"] / "-") "P" (dur-date / dur-time / dur-week)
dur-date = dur-day [dur-time]
dur-day = 1*DIGIT "D"

For example integer is defined as https://tools.ietf.org/html/rfc5545#section-3.3.8:
integer = (["+"] / "-") 1*DIGIT
indicating to me that "-2" in "P-2D" is not valid.

Comment 5

[Stefan Sitter [:ssitter]]

(In reply to Magnus Melin [:mkmelin] from comment #2)

Why is it beta specific?

The experimental icaljs library is enabled only on Trunk be default. All other branches use the matured libical library by default.

Comment 6

[Geoff Lankow (:darktrojan)]

You're probably right about it being invalid. It scarcely matters since it's not the point of the test, but since I'm now not rushing for a solution I've come up with a better one.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1643552-libical-period-string-2.diff

Let's do this instead. The last patch was stupid.

Comment 8

[Paul Morris [:pmorris]]

Comment on attachment 9154846 [details] [diff] [review]
1643552-libical-period-string-2.diff

Review of attachment 9154846 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, that is much nicer than the previous one.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4da3c65dedbf
Fix browser_attendeesDialog.js failing with libical. r=pmorris DONTBUILD

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/702239e687b7