1643557 - Fix more compile warnings in NSS

Status: RESOLVED FIXED

(NSS :: Libraries, task)

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Use unsigned int for log level, consistent with PRLogModuleLevel. r=kjacobs!

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Used unsigned int for two for-loops upper-bounded by unsigned ints in rsa_FormatOneBlock. r=kjacobs!

Depends on D78446

Comment 3

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Use size_t for a parameter-indexing variable to eliminate a signed-unsigned comparison warning. r=kjacobs!

Depends on D78447

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Use SECOidTag as the type of a loop variable over all values of that type to avoid a signed-unsigned comparison warning. r=kjacobs!

Depends on D78448

Comment 5

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Add PORT_AssertNotReached and use it instead of PORT_Assert(!"str"), which may warn about vacuous string literal to boolean conversions. r=kjacobs!

Depends on D78449

Comment 6

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Make pk11_MatchString accept a size_t length rather than an int length (consistent with all callers), and reformulate its internals to avoid a signed-unsigned comparison. r=kjacobs!

Depends on D78450

Comment 7

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Use size_t for various counts in pk11slot.c. r=kjacobs!

Depends on D78451

Comment 8

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Change the type of the size argument to pk11_FindObjectsByTemplate to be size_t, consistent with the type of some (small) numeric values passed to it after the previous revision. r=kjacobs!

Depends on D78452

Comment 9

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Make PK11_SetWrapKey explicitly handle being passed a negative wrap argument, to avoid a signed-unsigned comparison. r=kjacobs!

Depends on D78453

Comment 10

[Jeff Walden [:Waldo]]

Attachment: Bug 1643557 - Make pk11_FindObjectByTemplate accept a size_t count rather than a signed type to avoid internal signed-unsigned comparison warnings. r=kjacobs!

Depends on D78454

Comment 11

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/pushloghtml?changeset=5ee293d1a282abd28c0e0c27282420fe95d0340b

Thanks again.