1643625 - Clear up references to MAR_OLD_FORMAT in update tools

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, task)

Description

[Simon Fraser [:sfraser] ⌚️GMT]

We don't make bz2 updates any more, so we should clear out the code that accounts for it.

Files affected:
taskcluster/docker/funsize-update-generator/scripts/funsize.py
python/mozbuild/mozbuild/repackaging/mar.py
tools/update-packaging/unwrap_full_update.pl
tools/update-packaging/make_full_update.sh
tools/update-packaging/make_incremental_update.sh
tools/update-packaging/common.sh
tools/update-packaging/change_mar_compression.pl

Comment 1

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1643625 Clear up references to MAR_OLD_FORMAT in packaging tools

I think we don't need these checks any more.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37a5223eda5f
Clear up references to MAR_OLD_FORMAT in packaging tools r=nthomas

Comment 3

[Razvan Maries]

Backed out for build bustage.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=ZhhcyMs8QQaauPL3g9NZdg-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C2012%2Cx64%2Cshippable%2Copt%2Crepackage-win64-shippable%2Fopt%2C%28rpk%29&revision=37a5223eda5f4bfa171954a8e7a98f113c571e62

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305646702&repo=autoland&lineNumber=427

Backout: https://hg.mozilla.org/integration/autoland/rev/debaa06672d8d1ffab7df8f29453d076d691974e

Comment 4

[Simon Fraser [:sfraser] ⌚️GMT]

[task 2020-06-09T15:40:10.418Z] 15:40:10     INFO -  TypeError: repackage_mar() takes exactly 7 arguments (6 given)
[task 2020-06-09T15:40:10.418Z] 15:40:10     INFO -    File "/builds/worker/checkouts/gecko/python/mach/mach/main.py", line 475, in _run
[task 2020-06-09T15:40:10.418Z] 15:40:10     INFO -      **vars(args.command_args))
[task 2020-06-09T15:40:10.418Z] 15:40:10     INFO -    File "/builds/worker/checkouts/gecko/python/mach/mach/registrar.py", line 109, in _run_command_handler
[task 2020-06-09T15:40:10.418Z] 15:40:10     INFO -      result = fn(**kwargs)
[task 2020-06-09T15:40:10.433Z] 15:40:10    ERROR - Return code: 1

Turns out there are two repackage_mar functions. I'll update the other one as well.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/325d0a84cf46
Clear up references to MAR_OLD_FORMAT in packaging tools r=nthomas

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/325d0a84cf46