1643649 - Yomichan extension broken on Nighly

Status: RESOLVED WORKSFORME

(Firefox :: Extension Compatibility, defect)

Description

[SimonP]

I am not certain which API(s) this concerns, but the problem exists on Nightly and not on Release according to the extension developers.

To reproduce:

• Create a profile
• Install the Yomichan extension from https://github.com/FooSoft/yomichan
• Open Yomichan's options and attempt to import a dictionary

There are several issues:

• The options view is not populated until the extension button is clicked again
• Attempting to import a dictionary will fail
• If dictionaries were installed before, enumerating them will fail

See also these Github issues:

• https://github.com/FooSoft/yomichan/issues/588
• https://github.com/FooSoft/yomichan/issues/589

Comment 1

[toasted.nutbread]

Attachment: Example WebExtension exhibiting the issue

Comment 2

[toasted.nutbread]

Attached an example extension demonstrating the issue in Firefox Nightly 79.0a1 (~2020-06-05) where chrome.tabs.sendMessage doesn't work correctly. Using chrome.runtime.sendMessage instead seems to work.

Expected behaviour:

Upon opening settings.html:

// settings.html prints:
onMessage { message: { message: "test2" }, sender: { ... } }
response { response: true, error: null }

// bg.html prints:
onMessage { message: { message: "test" }, sender: { ... } }
response { response: true, error: null }

Observed behaviour:

Upon opening settings.html:

// settings.html prints:
response { response: true, error: null }

// bg.html prints:
onMessage { message: { message: "test" }, sender: { ... } }
response { response: undefined, error: { message: "Could not establish connection. Receiving end does not exist." } }

Comment 3

[Alice0775 White]

using attached extension "Example WebExtension exhibiting the issue"
Steps to reproduce:

1. Open Browser Console and enable "Show Content Messages"
2. Install the extension
3. Open about:addons and Click [...] of the extensions and choose "Options"

Actual results:
onMessage
Object { message: {…}, sender: {…} }
bg.js:4:11
response
Object { response: undefined, error: Error }
bg.js:9:13
response
Object { response: true, error: null }
settings.js:9:13

Expected results:
onMessage
Object { message: {…}, sender: {…} }
bg.js:4:11
onMessage
Object { message: {…}, sender: {…} }
settings.js:2:11
response
Object { response: true, error: null }
settings.js:9:13
response
Object { response: true, error: null }
bg.js:9:13

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e8d0f18c2300a223c31847d27196d1a8ad673515&tochange=ca3057f6cdc555f3ddfb1f10afa6805a43253a85

Comment 4

[Tomislav Jovanovic :zombie]

Thank you for the detailed report and minimal STR.

Marking this as duplicate of bug 1642967, as I already have a patch up there, and have confirmed Yomichan extension works with that applied locally.

This should be fixed in the next Nightly, but if you see further problems, please open a new bug.

Comment 5

[SimonP]

bug 1642967 did not completely resolve this. Enumerating dictionaries still failed after the fix for bug 1642967 was merged. However, something else seems to have solved the enumeration problem in the meantime, so I'm marking this as resolved.