Closed
Bug 1643661
Opened 5 years ago
Closed 5 years ago
Fix up shell quoting in scripts when calling 'hg' commands
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(firefox79 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: sfraser, Assigned: sfraser)
References
Details
Attachments
(1 file)
Some quote-free entries in shell scripts may be risky, we should clean those up:
/Users/sfraser/hg.m.o/mozilla-unified/taskcluster/docker/periodic-updates/scripts/periodic_file_updates.sh
409:12 error Double quote to prevent globbing and word splitting. 2086 (shellcheck)
410:12 error Double quote to prevent globbing and word splitting. 2086 (shellcheck)
/Users/sfraser/hg.m.o/mozilla-unified/taskcluster/docker/python-dependency-update/scripts/update_pipfiles.sh
33:12 error Double quote to prevent globbing and word splitting. 2086 (shellcheck)
34:12 error Double quote to prevent globbing and word splitting. 2086 (shellcheck)
|
Assignee | |
Comment 1•5 years ago
|
||
shellcheck will moan about this, as it's potentially unsafe
|
||
Updated•5 years ago
|
Assignee: nobody → sfraser
Status: NEW → ASSIGNED
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58e98c4dbecb
Fix shell quoting with hg commands r=mtabara
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•