1643693 - Perma [tier2] Windows 32-bit spidermonkey plain js\src\jit-test\tests\regexp\huge-02.js | Unknown (code 3221225725, args "") [0.2 s]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=305187807&repo=mozilla-central

TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\regexp\huge-02.js | Unknown (code 3221225725, args "") [0.2 s]
42691 TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\regexp\huge-02.js | Unknown (code 3221225725, args "--ion-eager --ion-offthread-compile=off --more-compartments") [0.2 s]
42702 TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\regexp\huge-02.js | Unknown (code 3221225725, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.2 s]
42713 TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\regexp\huge-02.js | Unknown (code 3221225725, args "--baseline-eager") [0.1 s]
42724 TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\regexp\huge-02.js | Unknown (code 3221225725, args "--no-blinterp --no-baseline --no-ion --more-compartments") [0.1 s]
42735 TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\regexp\huge-02.js | Unknown (code 3221225725, args "--blinterp-eager") [0.1 s]

Comment 1

[Iain Ireland [:iain]]

This is kind of baffling. Looking into it.

Comment 2

[Natalia Csoregi [:nataliaCs]]

Other failure example: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305369441&repo=mozilla-central&lineNumber=45808

Comment 3

[Intermittent Failures Robot]

11 failures in 4949 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 11

Platform breakdown:

• windows2012-32: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1643693&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 4

[Andreea Pavel [:apavel]]

Hi Iain, are there updates here?

Comment 5

[Iain Ireland [:iain]]

Slow progress, since I don't have access to a win32 machine and have to run tests on try.

I've narrowed the regexp/huge-02.js failures down to this changeset. I'm still not quite sure how moving some files around managed to break one and only one platform. Looking into it more today.

The other failures (in wasm/simd) appear to be unrelated.

Comment 6

[Andreea Pavel [:apavel]]

Thank you for the update!

Comment 7

[Iain Ireland [:iain]]

Update: This is some sort of unified build problem. When the changeset moved files around, the contents of the UNIFIED_SOURCES chunks changed. In particular, it looks like irregexp/imported/regexp-compiler.cc does not play nicely with at least one of the following files:

imported/regexp-ast.cc
imported/regexp-bytecode-generator.cc
imported/regexp-bytecode-peephole.cc
imported/regexp-bytecodes.cc
imported/regexp-compiler-tonode.cc

Pulling regexp-compiler.cc out of UNIFIED_SOURCES fixes the problem, but I'm going to run a couple more tests before landing that change to see if I can figure out what's going on, in case there's a real underlying problem. If nothing turns up, I'll land the simple fix.

Comment 8

[Intermittent Failures Robot]

31 failures in 5211 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-central: 31

Platform breakdown:

• windows2012-32: 31

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1643693&startday=2020-06-08&endday=2020-06-14&tree=all

Comment 9

[Iain Ireland [:iain]]

Attachment: Bug 1643693: Fix unified build issue on win32 r=mgaudet

After landing a patch to reorganize the directory structure of our irregexp import, one particular testcase (regexp/huge-02.js) started failing on Windows 32-bit. It turns out to be a unified build problem: moving around files caused the unified chunks to be allocated slightly differently. After some experimentation, I determined that pulling regexp-compiler.cc out of the unified build made the problem go away. It looks like it does not play nicely with regexp-compiler-tonode.cc. I don't have easy access to a win32 machine to dig deeper, so I'm landing the easy patch. If there's a real underlying issue, we can fix it when it shows up on a platform that's easier to debug.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/673b552a1d31
Fix unified build issue on win32 r=mgaudet

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/673b552a1d31