1643706 - Make WR tree printing more android-friendly

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

Right now doing e.g. spatial_tree.print() sends the tree-printed output to stdout which is totally useless on Android. On Android we instead want to send to logcat. In theory there's some hocus-pocus you can do to redirect stdout to logcat but I've never gotten that to work, so this is always a bit of a pain point for me when debugging WR on android.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=e2739266507bec9b828fb8be8e73f005d298c08e

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1643706 - Have the tree printer default to logcat on Android. r?kvark

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1643706 - Make spatial_tree.print() work on Android too. r?kvark

Instead of using the default TreePrinter implementation which sends output
to stdout, collect it into a Vec<u8> and use the debug! macro to log it,
which sends it to a more useful destination (logcat) on Android.

Depends on D78536

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e89164de2d6
Make spatial_tree.print() work on Android too. r=kvark

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4e89164de2d6