1643721 - Factor code relevant for serializing ranges out from `nsDocumentEncoder`

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 1) Factor range serialization state from `nsDocumentEncoder` out to `RangeSerializer`. r=masayuki

Preparation to move SerializeRangeNodes to RangeSerializer.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 2) Add `RangeNodeContext` to `nsDocumentEncoder` and `RangeSerializer`. r=masayuki

Preparatory step to move SerializeRangeNodes to RangeSerializer.

Depends on D79110

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 3) Factor initializing `mRangeSerializer`'s members out to `RangeSerializer::Initialize`. r=masayuki

Depends on D79111

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 4) Move `SerializeRangeNodes` to `RangeSerializer`. r=masayuki

Depends on D79112

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 5) Factor `RangeContextSerializer` out from `nsDocumentEncoder`. r=masayuki

Preparatory step to move SerializeRangeContextStart (End) to it.

Depends on D79113

Comment 6

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 6) Move `SerializeRangeContextStart` (End) to `RangeContextSerializer`. r=masayuki

Depends on D79114

Comment 7

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 7) Move `mCommonInclusiveAncestors` to `RangeSerializer`. r=masayuki

Preparation for moving SerializeRangeToString to RangeSerializer.

Comment 8

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 8) Move `SerializeRangeToString` to `RangeSerializer`. r=masayuki

Depends on D79118

Comment 9

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 9) Remove redundant `mRangeNodeContext` from `RangeSerializer`. r=masayuki

Depends on D79119

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 10) Privatize most members of `RangeSerializer`. r=masayuki

Comment 11

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 11) Privatize member of `RangeContextSerializer`. r=masayuki

Depends on D79288

Comment 12

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 12) Hide some details of `SerializeRangeToString` in `HasInvisibleParentAndShouldBeSkipped`. r=masayuki

Comment 13

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 13) Factor serializing a text node out. r=masayuki

Reduces code duplication.

Depends on D79421

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9be7ba2a8d44
part 1) Factor range serialization state from `nsDocumentEncoder` out to `RangeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e85cc7ee3711
part 2) Add `RangeNodeContext` to `nsDocumentEncoder` and `RangeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/c58faa33dff8
part 3) Factor initializing `mRangeSerializer`'s members out to `RangeSerializer::Initialize`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e6f4d89a3068
part 4) Move `SerializeRangeNodes` to `RangeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/8248d22c153a
part 5) Factor `RangeContextSerializer` out from `nsDocumentEncoder`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3ddc0b3e5eb1
part 6) Move `SerializeRangeContextStart` (End) to `RangeContextSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/539f59654c62
part 7) Move `mCommonInclusiveAncestors` to `RangeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/302c4255a4f7
part 8) Move `SerializeRangeToString` to `RangeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3df6cedb80c3
part 9) Remove redundant `mRangeNodeContext` from `RangeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/d82e23067320
part 10) Privatize most members of `RangeSerializer`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/73cb6ceaac11
part 11) Privatize member of `RangeContextSerializer`. r=masayuki

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bdc23677ca6
part 12) Hide some details of `SerializeRangeToString` in `HasInvisibleParentAndShouldBeSkipped`. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/bbcbf5721a9e
part 13) Factor serializing a text node out. r=masayuki

Comment 16

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 14) Change `SerializeToStringRecursive`'s `aDontSerializeRoot` to `enum class SerializeRoot` and drop negation. r=masayuki

Comment 17

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 15) Add assertion to `SerializeRangeNodes`. r=masayuki

Depends on D79482

Comment 18

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9be7ba2a8d44
https://hg.mozilla.org/mozilla-central/rev/e85cc7ee3711
https://hg.mozilla.org/mozilla-central/rev/c58faa33dff8
https://hg.mozilla.org/mozilla-central/rev/e6f4d89a3068
https://hg.mozilla.org/mozilla-central/rev/8248d22c153a
https://hg.mozilla.org/mozilla-central/rev/3ddc0b3e5eb1
https://hg.mozilla.org/mozilla-central/rev/539f59654c62
https://hg.mozilla.org/mozilla-central/rev/302c4255a4f7
https://hg.mozilla.org/mozilla-central/rev/3df6cedb80c3
https://hg.mozilla.org/mozilla-central/rev/d82e23067320
https://hg.mozilla.org/mozilla-central/rev/73cb6ceaac11
https://hg.mozilla.org/mozilla-central/rev/8bdc23677ca6
https://hg.mozilla.org/mozilla-central/rev/bbcbf5721a9e

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98914a797968
part 14) Change `SerializeToStringRecursive`'s `aDontSerializeRoot` to `enum class SerializeRoot` and drop negation. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ff293d87130e
part 15) Add assertion to `SerializeRangeNodes`. r=masayuki

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/98914a797968
https://hg.mozilla.org/mozilla-central/rev/ff293d87130e

Comment 21

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1643721: part 16) Factor `SerializeChildrenOfContent` functionality out. r=masayuki

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d5f6fbef8d4
part 16) Factor `SerializeChildrenOfContent` functionality out. r=masayuki

Comment 23

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6d5f6fbef8d4

Comment 24

[Takanori MATSUURA]

Is this bug should be closed?

Comment 25

[Mirko Brodesser (:mbrodesser-Igalia)]

We can close this ticket and open a new one when needed. The submitted work is self-contained.