Closed Bug 1643762 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 24014 - [css-lists] Fix list image gradient with dynamic zoom

Categories

(Core :: Layout: Generated Content, Lists, and Counters, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24014 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24014
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-lists] Fix list image gradient with dynamic zoom

The 'list-style-image' property accepts an \<image> value to be used as
the marker image for the list item. The problem was when specifying a
linear-gradient(), which has no intrinsic sizes. It would initially be
sized using half of the font ascent, but when dynamically changing the
'zoom' property, it would become 300x150.

This patch fixes it by changing LayoutImageResourceStyleImage::ImageSize
to use custom default sizes for list markers.

BUG=1091289

TEST=external/wpt/css/css-lists/list-style-image-zoom-dynamic.html

Change-Id: I746e2421ffb329df884457f0f973b30280fb23b3
Reviewed-on: https://chromium-review.googlesource.com/2230475
WPT-Export-Revision: 78adb007253c27c6cef82ed6a119610620e85c37

Component: web-platform-tests → Layout: Generated Content, Lists, and Counters
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1
FAIL : 1
ERROR: 1

Chrome

FAIL : 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-lists/list-style-image-zoom-dynamic.html: ERROR [GitHub], FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug], PASS [Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-windows10-64-opt, Gecko-windows7-32-opt] (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a63e38fdc20
[wpt PR 24014] - [css-lists] Fix list image gradient with dynamic zoom, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4627f772076c
[wpt PR 24014] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.