1643765 - Move gathering of ignored children to MOXAccessibleBase

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[Morgan Reschenberg [:morgan]]

Right now we rely on subclasses like mozAccessible to flatten our child list by recursing into ignored children and gathering unignored (grand) children. We should move this logic to MOXAccessibleBase for simplicity (given each subclass still correctly implements ignoreWithParent)

Comment 1

[Morgan Reschenberg [:morgan]]

Attachment: Bug 1643765: Add moxUnignoredChildren getter to MOXAccessibleBase r?eeejay

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7c1f66e9ff4
Add moxUnignoredChildren getter to MOXAccessibleBase r=eeejay

Comment 3

[Razvan Maries]

Backed out for build bustages.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=SqpEm-3KS76lk3sZx6NvLQ.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=os%2Cx%2Ccross%2Ccompiled%2Cdebug%2Cbuild-macosx64%2Fdebug%2C%28b%29&revision=e7c1f66e9ff4dfbec8fd14a3ba6f99199b6f54b4

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=308719898&repo=autoland&lineNumber=26482

Backout: https://hg.mozilla.org/integration/autoland/rev/fee4b634c2ee924f8bf6d27eb0d7cffc7f8ac27f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d3a31f6fcd6
Add moxUnignoredChildren getter to MOXAccessibleBase r=eeejay

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8d3a31f6fcd6

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 8d3a31f6fcd6 (bug 1643765) by morgan's request

Backout link: https://hg.mozilla.org/integration/autoland/rev/e3540b3df1814dca40f48340c3a4b53d2858d1b8

Comment 7

[Morgan Reschenberg [:morgan]]

thank you! backed out because intereactions between web area and chrome are broken (not gooooood)

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/e3540b3df181

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56806c2a625c
Add moxUnignoredChildren getter to MOXAccessibleBase r=eeejay

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/56806c2a625c