1643780 - Implement theme screen in multistage about:welcome

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to implement theme screen to support multistage about:welcome v2 round of experiments in 79

https://docs.google.com/document/d/1gm8vWNoBBXdRRfFaGZpkMVyJk0mTzidPUeljMEFQxc4/edit#heading=h.kwga5rwu7l69

Comment 1

[Punam Dahiya [:pdahiya]]

Created bug 1645824 to implement theme preview. Scope of this bug is to implement theme screen with light and dark theme as option, click of 'Save Theme' should keep selected theme and progress to next step. Clicking Secondary CTA link will revert to the default theme, and progress to the next step

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1643780 - Implement theme screen in multistage about:welcome

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot Theme Screen

Comment 5

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot Light Theme Preview

Comment 6

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot Dark Theme Preview

Comment 7

[Punam Dahiya [:pdahiya]]

NI Aaron for UI review of theme screens attached. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa0a5591f010
Implement theme screen in multistage about:welcome r=Mardak

Comment 9

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&searchStr=%28bc&revision=aa0a5591f0107b41e6e7fa1aa9ff31970c6d8100&selectedTaskRun=Ro2HeOQ7SSiEnMm3p8mWPA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=307305163&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e09e793c027aec0d7529e0347568b4305cf961a4

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90b514d14455
Implement theme screen in multistage about:welcome r=Mardak

Comment 11

[Cosmin Sabou [:CosminS]]

Looks like the failures were actually caused by Bug 1647470. Relanded. Please ignore comment 9.

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/90b514d14455

Comment 13

[Aaron Benson]

(In reply to Punam Dahiya [:pdahiya] from comment #7)

NI Aaron for UI review of theme screens attached. Thanks!

Sorry for the delay, have been out sick.

The two theme cards aren't centered. I would guess there's a right margin applied to the second (last) card which is pushing it off-center. We might consider a :last-child selector here so that no matter how many themes we have, there's no extra margin applied.

Other than that, looks good!

Comment 14

[Aaron Benson]

Oh, it also looks like the cards don't have the correct border-radius. The unselected card has a border radius on the bottom left/right corner but not the top, and the selected card has no border radius. See the spec for an example.

Comment 15

[Robert Martin [:romartin], Ecosystem QA]

Hey @Punam,

Will the fixes for the issues mentioned by @Aaron in comment 13, and comment 14 be handled in this bug or there will be another one logged?

Comment 16

[Punam Dahiya [:pdahiya]]

(In reply to Robert Martin [:romartin], Ecosystem QA from comment #15)

Hey @Punam,

Will the fixes for the issues mentioned by @Aaron in comment 13, and comment 14 be handled in this bug or there will be another one logged?

Hi Robert!
Aaaron UI review feedback fixes were rolled in with UI fixes in bug 1648538 and should be fixed in today's Nightly. Thanks!

Comment 17

[Robert Martin [:romartin], Ecosystem QA]

I have verified that there is a "theme screen" correctly displayed in the "about:welcome" page using Firefox Nightly 80.0a1 (Build ID: 20200629154604) and Firefox Beta 79.0b1 (2020069224419) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 18.04.

Given the above and comment 16, I'm marking this enhancement as VERIFIED.