Move feature policy check for fullscreen to the right place.
Categories
(Core :: DOM: Security, defect, P2)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
Details
(Whiteboard: [domsecurity-active], [wptsync upstream])
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
8.04 KB,
patch
|
RyanVM
:
approval-mozilla-esr78+
|
Details | Diff | Splinter Review |
Assignee | ||
Comment 1•4 years ago
|
||
See bug 1606660 comment 8 as to why checking it only in
Element.requestFullscreen is wrong.
Do you know how to test this? I'm not very familiar with feature-policy.
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Backed out for mochitest failures on test_fullscreen-api.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/7b46af31bb56436eeb7115f5e2d0a977fa4de305
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307129113&repo=autoland&lineNumber=4707
Comment 6•4 years ago
|
||
Also wpt failures on fullscreen-reporting.html
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=307129275&repo=autoland&lineNumber=1013
Assignee | ||
Updated•4 years ago
|
Comment 10•4 years ago
|
||
bugherder |
Assignee | ||
Comment 12•4 years ago
|
||
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed for bug 1608358 not to cause regressions.
User impact if declined: see bug 1608358
Fix Landed on Version: 79
Risk to taking this patch (and alternatives if risky): pretty low risk.
See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.
Comment 13•4 years ago
|
||
Comment on attachment 9188113 [details] [diff] [review]
ESR patch
Approved for 78.6esr.
Comment 14•4 years ago
|
||
bugherder uplift |
Description
•