Closed Bug 1643798 Opened 4 years ago Closed 4 years ago

Move feature policy check for fullscreen to the right place.

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox-esr78 --- fixed
firefox79 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

(Whiteboard: [domsecurity-active], [wptsync upstream])

Attachments

(2 files)

See bug 1606660 comment 8 as to why checking it only in
Element.requestFullscreen is wrong.

Do you know how to test this? I'm not very familiar with feature-policy.

Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ff0e5800b2f Fix feature policy check for fullscreen so that it gets reflected properly in document.fullscreenEnabled. r=baku
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/24294 for changes under testing/web-platform/tests
Whiteboard: [domsecurity-active] → [domsecurity-active], [wptsync upstream]
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR was closed without merging
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83b6b0a9ec8e Fix feature policy check for fullscreen so that it gets reflected properly in document.fullscreenEnabled. r=baku
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Upstream PR merged by moz-wptsync-bot
Attached patch ESR patchSplinter Review

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed for bug 1608358 not to cause regressions.
User impact if declined: see bug 1608358
Fix Landed on Version: 79
Risk to taking this patch (and alternatives if risky): pretty low risk.

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Attachment #9188113 - Flags: approval-mozilla-esr78?

Comment on attachment 9188113 [details] [diff] [review]
ESR patch

Approved for 78.6esr.

Attachment #9188113 - Attachment is patch: true
Attachment #9188113 - Flags: approval-mozilla-esr78? → approval-mozilla-esr78+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: