1643804 - Errors notifying extension storage listeners can hang the sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Lina Butler (ex-Mozilla)]

Thanks to Thom for catching this! We can fail to fetch pending listener notifications if there's a database error, or an error punting the operation to the background thread. We log the error, but don't resolve or reject the promise, so the sync just hangs.

Comment 1

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1643804 - Always resolve the promise if fetching extension storage observer notifications fails. r?tcsc!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caae35501433
Always resolve the promise if fetching extension storage observer notifications fails. r=tcsc

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/caae35501433

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Lina, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[Lina Butler (ex-Mozilla)]

Comment on attachment 9154664 [details]
Bug 1643804 - Always resolve the promise if fetching extension storage observer notifications fails. r?tcsc!

Beta/Release Uplift Approval Request

• User impact if declined: Extension storage syncs never completing if an unexpected error occurs while fetching information for observer notifications during the sync.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a one-line change that adds a missing resolve call (without which the promise would remain pending forever if an error occurred), and an xpcshell test for the success and error cases in the function.
• String changes made/needed: None

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9154664 [details]
Bug 1643804 - Always resolve the promise if fetching extension storage observer notifications fails. r?tcsc!

approved for 78.0b5

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/32c33451e443