1643858 - Search engine is not restored/reset when the add-on is uninstalled at early startup

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P3)

Description

[Rob Wu [:robwu]]

STR:

1. Install a search engine, e.g. https://addons.mozilla.org/en-US/firefox/addon/bing-search-engine-/versions/
2. In the "[name] would like to change your default search engine ..." prompt, choose Yes.
3. Quit Firefox.
4. Delete the extension file - extensions/{8d8ca802-6b23-43ed-9445-e05d48579542}.xpi
5. Start Firefox and check your default search engine

Expected:

• It should be the default search engine from a fresh install, e.g. Google.

Actual:

• The engine that you had installed in step 1, i.e. Bing Search.

Comment 1

[Tomislav Jovanovic :zombie]

Hey Mark, can you please look into this?

Comment 2

[Mark Banner (:standard8)]

I came across this the other day that looks suspicious:

https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/browser/components/extensions/parent/ext-chrome-settings-overrides.js#240

We don't seem to be handling that here, which is where I'd expect:

https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/toolkit/components/search/SearchService.jsm#1717

So assuming the removeEngine in the WebExtension part is being called, then we probably need to handle this correctly in the search service.

I need to look at this a bit more, and it might be related to a bug we've just discussed with QA, so I'll leave the NI open and hopefully have a look at it in more detail next week.

Comment 3

[Mark Banner (:standard8)]

I've started to look at this, I don't think it is too urgent, but would be good to get fixed anyway whilst we're doing search service cleanup.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1643858 - When an add-on is uninstalled at early startup, ensure that we also remove associated search engines. r?mixedpuppy!,daleharvey!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d18224bb657a
When an add-on is uninstalled at early startup, ensure that we also remove associated search engines. r=mixedpuppy,daleharvey

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d18224bb657a

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

I have managed to reproduce the issue using Fx79.0a1.
The issue is verified fixed using the latest Fx84.0a1 on Windows 10, Ubuntu 18.04 and macOS 10.14. The switch back to the default engine is done successfully after the addon removal.