Closed Bug 1643873 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 24023 - Implement the media element 'show poster flag' in accordance with spec

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24023 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24023
Details from upstream follow.

Will Cassella <cassew@google.com> wrote:

Implement the media element 'show poster flag' in accordance with spec

Previously, HTMLMediaElement had a 'DisplayMode' enum which was one of
{ 'kUnknown', 'kPoster', 'kVideo' }. This didn't mesh well with the
spec, which only mentions the 'show poster flag' as being true or false.
This flag is also present for audio elements, which makes the state of
'kVideo' somewhat strange.

Additionally, the points where this mode was changed were inconsistent
with the spec, and resulted in us showing video contents when we should
be showing the poster, and makes implementing other features dependent
on the state of the 'show poster flag' difficult, such as the cue
timeline.

This CL removes 'DisplayMode' from HTMLMediaElement (though reintroduces
it in a limited form in LayoutVideo), and implements the
'show-poster-flag' in accordance with the spec. This makes the behavior
of poster rendering (as detailed in the attached bug) consistent with
Firefox and Safari.

Bug: 1007241
Change-Id: Iaaf3a10581357443b7889578360852e0a674e68c
Reviewed-on: https://chromium-review.googlesource.com/2222948
WPT-Export-Revision: da70aa475b093555b6f199a23b910b064401df85

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

FAIL : 1

Safari

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c0ce0a37205
[wpt PR 24023] - Implement the media element 'show poster flag' in accordance with spec, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.